Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ACS-6748] BasicAlfrescoAuthService.requireAlfTicket should not be in adf/core #9393

Merged
merged 3 commits into from
Mar 4, 2024
Merged

[ACS-6748] BasicAlfrescoAuthService.requireAlfTicket should not be in adf/core #9393

merged 3 commits into from
Mar 4, 2024

Conversation

dominikiwanekhyland
Copy link
Contributor

@dominikiwanekhyland dominikiwanekhyland commented Mar 1, 2024 •
edited
Loading

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (check one with "x")

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation
  • Other... Please describe:

What is the current behaviour? (You can also link to an open issue here)
requireAlfTicket is triggered in apps which don't need it and it causes errors in console.

What is the new behaviour?
https://alfresco.atlassian.net/browse/ACS-6748
requireAlfTicket method is triggered only when necessary.

Does this PR introduce a breaking change? (check one with "x")

  • Yes
  • No

If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...

Other information:

@AleksanderSklorz
Copy link
Contributor

@dominikiwanekhyland could you please add some unit tests to new code?

@dominikiwanekhyland dominikiwanekhyland force-pushed the ACS-6748-basic-alfresco-auth-service-require-alf-ticket-should-not-be-in-adf-core branch from 4f79f1b to a3e2086 Compare March 1, 2024 13:42
@dominikiwanekhyland dominikiwanekhyland force-pushed the ACS-6748-basic-alfresco-auth-service-require-alf-ticket-should-not-be-in-adf-core branch from a3e2086 to 0f60768 Compare March 1, 2024 14:03
wideLandscape
wideLandscape reviewed Mar 1, 2024
View reviewed changes
Copy link
Contributor

@wideLandscape wideLandscape left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good work so far!

lib/content-services/src/lib/auth-loader/content-auth-loader.service.ts Outdated Show resolved Hide resolved
lib/content-services/src/lib/content.module.ts Show resolved Hide resolved
@dominikiwanekhyland dominikiwanekhyland force-pushed the ACS-6748-basic-alfresco-auth-service-require-alf-ticket-should-not-be-in-adf-core branch from 0f60768 to 9918229 Compare March 1, 2024 15:48
wideLandscape
wideLandscape approved these changes Mar 1, 2024
View reviewed changes
Copy link
Contributor

@wideLandscape wideLandscape left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great work! thanks for fixing this!

@dominikiwanekhyland dominikiwanekhyland force-pushed the ACS-6748-basic-alfresco-auth-service-require-alf-ticket-should-not-be-in-adf-core branch from 625315d to ab70d01 Compare March 4, 2024 08:09
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Mar 4, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@dominikiwanekhyland dominikiwanekhyland merged commit 325eef1 into develop Mar 4, 2024
33 checks passed
@dominikiwanekhyland dominikiwanekhyland deleted the ACS-6748-basic-alfresco-auth-service-require-alf-ticket-should-not-be-in-adf-core branch March 4, 2024 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AleksanderSklorz AleksanderSklorz AleksanderSklorz approved these changes

@swapnil-verma-gl swapnil-verma-gl swapnil-verma-gl approved these changes

@wideLandscape wideLandscape wideLandscape approved these changes

@eromano eromano Awaiting requested review from eromano eromano is a code owner

@popovicsandras popovicsandras Awaiting requested review from popovicsandras popovicsandras is a code owner

@DenysVuika DenysVuika Awaiting requested review from DenysVuika DenysVuika is a code owner

@MichalKinas MichalKinas Awaiting requested review from MichalKinas

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dominikiwanekhyland @AleksanderSklorz @wideLandscape @swapnil-verma-gl