AAE 21001 enable AAE e2es #9411
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acichon-h
reviewed
Mar 7, 2024
Comment on lines
-28
to
-29
| "C290040": "https://alfresco.atlassian.net/browse/ACS-6930", | ||
| "C286598": "https://alfresco.atlassian.net/browse/ACS-6930", |
There was a problem hiding this comment.
Citing PR description: removing C290040, test like this exist in hxp as C286598. I understand that as:
- there's a test
C286598inhxp-frontend-apps, which coversC290040 C290040is then redundant- the conclusion is that
C290040is to be removed
What this PR does:
- removes
C290040 - enables
C286598
I couldn't find C286598 in hxp-frontend-apps and even if I missed it, I don't think we should have two different tests with the same id, even if they are in different repos.
There was a problem hiding this comment.
I think I made some mistake with copy paste of the test numbers.
- Removing C290040 from ADF -> in hxp its C633731
- Was enabling C286598 here, but need some more investigation as it still fails.
There was a problem hiding this comment.
Please ask for rereview once it's passing or disabled again
rafalszmit
force-pushed
the
test/AAE-21001-enable-aae-e2es
branch
from
2ae9fb0 to
189c603
Compare
acichon-h
approved these changes
Mar 8, 2024
rafalszmit
force-pushed
the
test/AAE-21001-enable-aae-e2es
branch
from
c006092 to
f79e84d
Compare
|
AleksanderSklorz
pushed a commit
that referenced
this pull request
Mar 27, 2024
* AAE-21001 enable AAE e2es * remove duplicated e2e * [ci:force] trigger ci * [ci:force] trigger ci * fix C286598
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (check one with "x")
What is the current behaviour? (You can also link to an open issue here)
What is the new behaviour?
removing C290040, test like this exist in hxp as C286598
Does this PR introduce a breaking change? (check one with "x")
If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...
Other information: