Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AAE-21233 Enable no angular material selectors rule for adf #9430

Merged
merged 3 commits into from
Apr 9, 2024

Conversation

wojd0
Copy link
Contributor

@wojd0 wojd0 commented Mar 13, 2024

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (check one with "x")

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation
  • Other... Please describe:

What is the current behaviour? (You can also link to an open issue here)

https://hyland.atlassian.net/browse/AAE-21233

What is the new behaviour?

Enables eslint rule for angular selectors.

Does this PR introduce a breaking change? (check one with "x")

  • Yes
  • No

If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...

Other information:

Check if this approach is correct, as enabling a eslint rule within the same repo it's created isn't so straight-forward.

@wojd0 wojd0 changed the title AAE-20779 enable no angular material selectors rule for adf AAE-20779 AAE-21233 enable no angular material selectors rule for adf Mar 15, 2024
@wojd0 wojd0 changed the title AAE-20779 AAE-21233 enable no angular material selectors rule for adf AAE-21233 Enable no angular material selectors rule for adf Apr 5, 2024
@wojd0 wojd0 force-pushed the feature/AAE-20779-enable-no-mat-selectors-rule branch from a7e2446 to 7a4e17b Compare April 9, 2024 07:38
@wojd0 wojd0 marked this pull request as ready for review April 9, 2024 07:40
@wojd0 wojd0 force-pushed the feature/AAE-20779-enable-no-mat-selectors-rule branch from b2b8287 to 5130536 Compare April 9, 2024 11:59
@wojd0
Copy link
Contributor Author

wojd0 commented Apr 9, 2024

waiting on remaining lib fixes to be merged #9517 and #9514

Copy link
Contributor

@ehsan-2019 ehsan-2019 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@wojd0 wojd0 force-pushed the feature/AAE-20779-enable-no-mat-selectors-rule branch from 5130536 to 7ecaefc Compare April 9, 2024 12:39
Copy link

sonarqubecloud bot commented Apr 9, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@wojd0 wojd0 merged commit 5494aa8 into develop Apr 9, 2024
33 checks passed
@wojd0 wojd0 deleted the feature/AAE-20779-enable-no-mat-selectors-rule branch April 9, 2024 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants