Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ACS-7242] Resizing columns with panel opened on the right, e.g. nfo … #9446

Conversation

jacekpluta
Copy link
Contributor

@jacekpluta jacekpluta commented Mar 18, 2024

…Drawer creates empty columns space when panel is closed.

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (check one with "x")

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation
  • Other... Please describe:

What is the current behaviour? (You can also link to an open issue here)
https://alfresco.atlassian.net/browse/ACS-7242

What is the new behaviour?
After talking to Share, we decided to remove the resize handler of the last column.
The last column should always take the rest of the remaining space (have flex-grow property) and should not be resizable by user.

Does this PR introduce a breaking change? (check one with "x")

  • Yes
  • No

If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...

Other information:

…Drawer creates empty columns space when panel is closed.
@jacekpluta jacekpluta force-pushed the ACS-7242-Resizing-columns-with-panel-opened-on-the-right-nfo-Drawer-creates-empty-columns-space branch from 1a9a02d to ed30691 Compare March 18, 2024 09:13
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@jacekpluta jacekpluta merged commit c3459c4 into develop Mar 18, 2024
33 checks passed
@jacekpluta jacekpluta deleted the ACS-7242-Resizing-columns-with-panel-opened-on-the-right-nfo-Drawer-creates-empty-columns-space branch March 18, 2024 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants