Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ACS-6927] - Fully compliant with OIDC: ADF #9452

Merged
merged 2 commits into from
Mar 22, 2024
Merged

[ACS-6927] - Fully compliant with OIDC: ADF #9452

merged 2 commits into from
Mar 22, 2024

Conversation

dominikiwanekhyland
Copy link
Contributor

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (check one with "x")

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation
  • Other... Please describe:

What is the current behaviour? (You can also link to an open issue here)
https://alfresco.atlassian.net/browse/ACS-6927
ADF is dependent from Keycloak for SSO login.

What is the new behaviour?
It's possible to configure other IdPs for SSO login.

Does this PR introduce a breaking change? (check one with "x")

  • Yes
  • No

If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...

Other information:

@dominikiwanekhyland dominikiwanekhyland force-pushed the ACS-6927-fully-compliant-with-oidc-adf branch from d4ef6a9 to 25cce1f Compare March 21, 2024 14:01
@dominikiwanekhyland dominikiwanekhyland force-pushed the ACS-6927-fully-compliant-with-oidc-adf branch from 25cce1f to ffa916a Compare March 22, 2024 13:18
@dominikiwanekhyland dominikiwanekhyland force-pushed the ACS-6927-fully-compliant-with-oidc-adf branch from ffa916a to 3de6027 Compare March 22, 2024 14:45
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@DenysVuika DenysVuika merged commit deea720 into develop Mar 22, 2024
33 checks passed
@DenysVuika DenysVuika deleted the ACS-6927-fully-compliant-with-oidc-adf branch March 22, 2024 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AleksanderSklorz AleksanderSklorz AleksanderSklorz approved these changes

@DenysVuika DenysVuika DenysVuika approved these changes

@nikita-web-ua nikita-web-ua Awaiting requested review from nikita-web-ua

@swapnil-verma-gl swapnil-verma-gl Awaiting requested review from swapnil-verma-gl

@vprovaggi vprovaggi Awaiting requested review from vprovaggi

@MichalKinas MichalKinas Awaiting requested review from MichalKinas

@eromano eromano Awaiting requested review from eromano eromano is a code owner

@popovicsandras popovicsandras Awaiting requested review from popovicsandras popovicsandras is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dominikiwanekhyland @DenysVuika @AleksanderSklorz