[ACS-8055] Integrate endpoint for getting Legal Holds #9771

DaryaBalvanovich · 2024-06-05T11:08:54Z

Please check if the PR fulfills these requirements

https://hyland.atlassian.net/browse/ACS-8055

The commit message follows our guidelines

Tests for the changes have been added (for bug fixes / features)

Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (check one with "x")

Bugfix

Feature

Code style update (formatting, local variables)

Refactoring (no functional changes, no api changes)

Build related changes

Documentation

Other... Please describe:

What is the current behaviour? (You can also link to an open issue here)
no endpoints to get legal holds

What is the new behaviour?

integrated new endpoint to get all legal holds
using existing endpoint to get assigned holds for the node
create legal holds service

Does this PR introduce a breaking change? (check one with "x")

Yes

No

If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...

Other information:

docs/core/services/nodes-api.service.md

lib/content-services/src/lib/common/services/nodes-api.service.ts

lib/js-api/src/api/gs-core-rest-api/api/legal-hold.api.ts

lib/js-api/src/api/gs-core-rest-api/model/hold.ts

lib/js-api/src/api/gs-core-rest-api/api/legal-hold.api.ts

lib/js-api/src/api/content-rest-api/model/nodeChildAssociation.ts

lib/content-services/src/lib/legal-hold/services/legal-hold.service.ts

lib/content-services/src/lib/common/services/nodes-api.service.ts

MichalKinas · 2024-06-12T06:47:25Z

Also PR is missing the Jira ticket link and a description

lib/content-services/src/lib/common/services/nodes-api.service.ts

lib/content-services/src/lib/legal-hold/services/legal-holds.service.spec.ts

lib/js-api/src/api/gs-core-rest-api/README.md

lib/js-api/src/api/gs-core-rest-api/model/holdEntry.ts

lib/content-services/src/lib/common/services/nodes-api.service.ts

lib/content-services/src/lib/legal-hold/services/legal-hold.service.ts

lib/js-api/src/api/gs-core-rest-api/model/hold.ts

lib/content-services/src/lib/legal-hold/services/legal-hold.service.ts

lib/js-api/src/api/gs-core-rest-api/api/legal-hold.api.ts

lib/content-services/src/lib/legal-hold/services/legal-hold.service.ts

AleksanderSklorz · 2024-06-18T08:55:22Z

@DaryaBalvanovich I can see files with changes where you have no unit tests. Please add unit tests to all places which you added/changed

docs/content-services/services/legal-hold.service.md

sonarqubecloud · 2024-06-19T15:47:44Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

* ACS-8055 add listAssignedHolds API * ACS-8055 create legal-hold service * ACS-8055 add documentation * ACS-8055 fix imports * ACS-8055 clean up code * ACS-8055 fix interface typo * ACS-8055 add optional options and uodate nodes-api.service.md * ACS-8055 update interface * ACS-8055 add HoldPaging class and documentation * ACS-8055 add interface and fix test * ACS-8055 add documentation for legal hold service * ACS-8055 update legal-hold.service.md * ACS-8055 update legal-hold.service.md * ACS-8055 update readme file * ACS-8055 add translation --------- Co-authored-by: DaryaBalvanovich <[email protected]>

* [ACS-8055] Integrate endpoint for getting Legal Holds (#9771) * ACS-8055 add listAssignedHolds API * ACS-8055 create legal-hold service * ACS-8055 add documentation * ACS-8055 fix imports * ACS-8055 clean up code * ACS-8055 fix interface typo * ACS-8055 add optional options and uodate nodes-api.service.md * ACS-8055 update interface * ACS-8055 add HoldPaging class and documentation * ACS-8055 add interface and fix test * ACS-8055 add documentation for legal hold service * ACS-8055 update legal-hold.service.md * ACS-8055 update legal-hold.service.md * ACS-8055 update readme file * ACS-8055 add translation --------- Co-authored-by: DaryaBalvanovich <[email protected]> * ACS-7689 Save and delete to existing hold (#9841) * [ACS-7690] Saving adding o a new hold (#9862) * ACS-7689 Save and delete to existing hold * ACS-7689 Save and delete to existing hold, cleanup * ACS-7689 Save and delete to existing hold, revert to separate methods * ACS-7689 Save and delete to existing hold, fix specs * ACS-7689 Save and delete to existing hold, fix specs * ACS-7689 Save and delete to existing hold * ACS-8055 add listAssignedHolds API * ACS-8055 create legal-hold service * ACS-8055 add documentation * ACS-8055 fix imports * ACS-8055 add HoldPaging class and documentation * ACS-8055 add interface and fix test * ACS-7689 Save and delete to existing hold, fix specs * ACS-7689 Save and delete to existing hold, fix specs * ACS-7690 integrate create and assign holds endpoints * ACS-7690 fix imports * ACS-7690 add bulk method * ACS-7690 update readme file * ACS-7690 add tests * ACS-7690 update docs file * ACS-7690 remove interface * ACS-7690 update geHolds description and md file with createHold * ACS-7690 add createHolds to md file * ACS-7690 fix typo in spec, and description in legal-hold service * ACS-7690 refactor create hold parameter and documentation * ACS-7690 fixed test * ACS-7690 fix test for getHolds * ACS-7690 fix md for create hold action * ACS-7690 fix rebase conflicts --------- Co-authored-by: Tomasz Nastaly <[email protected]> Co-authored-by: DaryaBalvanovich <[email protected]> * ACS-7689 Update payload with hold id (#9877) * ACS-7600 fix documentation and method name * ACS-7600 create separate type for hold creation * [ACS-8036] [FE] Legal Hold in ADW. Part 2 (Bulk) (#10062) * ACS-8329 Manage bulks endpoint (#9972) * ACS-8325 extend ContentActionRef with tooltip (#9998) * [ACS-8425] Add functionality to select folder and assign it to a hold (#10011) * ACS-8425 add bulkFolderHold method * ACS-8425 refactor names and add more specific query to folder * ACS-8425 refactor names * ACS-8425 fix description in md file * ACS-8425 update interfaces and add constant * ACS-8425 fix readme file and refactor tests * ACS-8425 fix readme * ACS-8425 fix readme * ACS-8036 fix import path --------- Co-authored-by: Tomasz Nastaly <[email protected]> * [ACS-7600] fix imports in dropdown widget * [ACS-7600] fix Hold interface and documentation * [ACS-7600] fix hold interfaces and documentation * [ACS-7600] fix hold interfaces and documentation * [ACS-7600] fix hold interfaces and documentation * [ACS-7600] fix hold interfaces and documentation * [ACS-7600] fix hold interfaces and documentation * [ACS-7600] fix hold interfaces and documentation --------- Co-authored-by: Darya Blavanovich <[email protected]> Co-authored-by: DaryaBalvanovich <[email protected]> Co-authored-by: tomson <[email protected]> Co-authored-by: g-jaskowski <[email protected]>

* ACS-8055 add listAssignedHolds API * ACS-8055 create legal-hold service * ACS-8055 add documentation * ACS-8055 fix imports * ACS-8055 clean up code * ACS-8055 fix interface typo * ACS-8055 add optional options and uodate nodes-api.service.md * ACS-8055 update interface * ACS-8055 add HoldPaging class and documentation * ACS-8055 add interface and fix test * ACS-8055 add documentation for legal hold service * ACS-8055 update legal-hold.service.md * ACS-8055 update legal-hold.service.md * ACS-8055 update readme file * ACS-8055 add translation --------- Co-authored-by: DaryaBalvanovich <[email protected]>

* [ACS-8055] Integrate endpoint for getting Legal Holds (#9771) * ACS-8055 add listAssignedHolds API * ACS-8055 create legal-hold service * ACS-8055 add documentation * ACS-8055 fix imports * ACS-8055 clean up code * ACS-8055 fix interface typo * ACS-8055 add optional options and uodate nodes-api.service.md * ACS-8055 update interface * ACS-8055 add HoldPaging class and documentation * ACS-8055 add interface and fix test * ACS-8055 add documentation for legal hold service * ACS-8055 update legal-hold.service.md * ACS-8055 update legal-hold.service.md * ACS-8055 update readme file * ACS-8055 add translation --------- Co-authored-by: DaryaBalvanovich <[email protected]> * ACS-7689 Save and delete to existing hold (#9841) * [ACS-7690] Saving adding o a new hold (#9862) * ACS-7689 Save and delete to existing hold * ACS-7689 Save and delete to existing hold, cleanup * ACS-7689 Save and delete to existing hold, revert to separate methods * ACS-7689 Save and delete to existing hold, fix specs * ACS-7689 Save and delete to existing hold, fix specs * ACS-7689 Save and delete to existing hold * ACS-8055 add listAssignedHolds API * ACS-8055 create legal-hold service * ACS-8055 add documentation * ACS-8055 fix imports * ACS-8055 add HoldPaging class and documentation * ACS-8055 add interface and fix test * ACS-7689 Save and delete to existing hold, fix specs * ACS-7689 Save and delete to existing hold, fix specs * ACS-7690 integrate create and assign holds endpoints * ACS-7690 fix imports * ACS-7690 add bulk method * ACS-7690 update readme file * ACS-7690 add tests * ACS-7690 update docs file * ACS-7690 remove interface * ACS-7690 update geHolds description and md file with createHold * ACS-7690 add createHolds to md file * ACS-7690 fix typo in spec, and description in legal-hold service * ACS-7690 refactor create hold parameter and documentation * ACS-7690 fixed test * ACS-7690 fix test for getHolds * ACS-7690 fix md for create hold action * ACS-7690 fix rebase conflicts --------- Co-authored-by: Tomasz Nastaly <[email protected]> Co-authored-by: DaryaBalvanovich <[email protected]> * ACS-7689 Update payload with hold id (#9877) * ACS-7600 fix documentation and method name * ACS-7600 create separate type for hold creation * [ACS-8036] [FE] Legal Hold in ADW. Part 2 (Bulk) (#10062) * ACS-8329 Manage bulks endpoint (#9972) * ACS-8325 extend ContentActionRef with tooltip (#9998) * [ACS-8425] Add functionality to select folder and assign it to a hold (#10011) * ACS-8425 add bulkFolderHold method * ACS-8425 refactor names and add more specific query to folder * ACS-8425 refactor names * ACS-8425 fix description in md file * ACS-8425 update interfaces and add constant * ACS-8425 fix readme file and refactor tests * ACS-8425 fix readme * ACS-8425 fix readme * ACS-8036 fix import path --------- Co-authored-by: Tomasz Nastaly <[email protected]> * [ACS-7600] fix imports in dropdown widget * [ACS-7600] fix Hold interface and documentation * [ACS-7600] fix hold interfaces and documentation * [ACS-7600] fix hold interfaces and documentation * [ACS-7600] fix hold interfaces and documentation * [ACS-7600] fix hold interfaces and documentation * [ACS-7600] fix hold interfaces and documentation * [ACS-7600] fix hold interfaces and documentation --------- Co-authored-by: Darya Blavanovich <[email protected]> Co-authored-by: DaryaBalvanovich <[email protected]> Co-authored-by: tomson <[email protected]> Co-authored-by: g-jaskowski <[email protected]>

* ACS-8055 add listAssignedHolds API * ACS-8055 create legal-hold service * ACS-8055 add documentation * ACS-8055 fix imports * ACS-8055 clean up code * ACS-8055 fix interface typo * ACS-8055 add optional options and uodate nodes-api.service.md * ACS-8055 update interface * ACS-8055 add HoldPaging class and documentation * ACS-8055 add interface and fix test * ACS-8055 add documentation for legal hold service * ACS-8055 update legal-hold.service.md * ACS-8055 update legal-hold.service.md * ACS-8055 update readme file * ACS-8055 add translation --------- Co-authored-by: DaryaBalvanovich <[email protected]>

* [ACS-8055] Integrate endpoint for getting Legal Holds (#9771) * ACS-8055 add listAssignedHolds API * ACS-8055 create legal-hold service * ACS-8055 add documentation * ACS-8055 fix imports * ACS-8055 clean up code * ACS-8055 fix interface typo * ACS-8055 add optional options and uodate nodes-api.service.md * ACS-8055 update interface * ACS-8055 add HoldPaging class and documentation * ACS-8055 add interface and fix test * ACS-8055 add documentation for legal hold service * ACS-8055 update legal-hold.service.md * ACS-8055 update legal-hold.service.md * ACS-8055 update readme file * ACS-8055 add translation --------- Co-authored-by: DaryaBalvanovich <[email protected]> * ACS-7689 Save and delete to existing hold (#9841) * [ACS-7690] Saving adding o a new hold (#9862) * ACS-7689 Save and delete to existing hold * ACS-7689 Save and delete to existing hold, cleanup * ACS-7689 Save and delete to existing hold, revert to separate methods * ACS-7689 Save and delete to existing hold, fix specs * ACS-7689 Save and delete to existing hold, fix specs * ACS-7689 Save and delete to existing hold * ACS-8055 add listAssignedHolds API * ACS-8055 create legal-hold service * ACS-8055 add documentation * ACS-8055 fix imports * ACS-8055 add HoldPaging class and documentation * ACS-8055 add interface and fix test * ACS-7689 Save and delete to existing hold, fix specs * ACS-7689 Save and delete to existing hold, fix specs * ACS-7690 integrate create and assign holds endpoints * ACS-7690 fix imports * ACS-7690 add bulk method * ACS-7690 update readme file * ACS-7690 add tests * ACS-7690 update docs file * ACS-7690 remove interface * ACS-7690 update geHolds description and md file with createHold * ACS-7690 add createHolds to md file * ACS-7690 fix typo in spec, and description in legal-hold service * ACS-7690 refactor create hold parameter and documentation * ACS-7690 fixed test * ACS-7690 fix test for getHolds * ACS-7690 fix md for create hold action * ACS-7690 fix rebase conflicts --------- Co-authored-by: Tomasz Nastaly <[email protected]> Co-authored-by: DaryaBalvanovich <[email protected]> * ACS-7689 Update payload with hold id (#9877) * ACS-7600 fix documentation and method name * ACS-7600 create separate type for hold creation * [ACS-8036] [FE] Legal Hold in ADW. Part 2 (Bulk) (#10062) * ACS-8329 Manage bulks endpoint (#9972) * ACS-8325 extend ContentActionRef with tooltip (#9998) * [ACS-8425] Add functionality to select folder and assign it to a hold (#10011) * ACS-8425 add bulkFolderHold method * ACS-8425 refactor names and add more specific query to folder * ACS-8425 refactor names * ACS-8425 fix description in md file * ACS-8425 update interfaces and add constant * ACS-8425 fix readme file and refactor tests * ACS-8425 fix readme * ACS-8425 fix readme * ACS-8036 fix import path --------- Co-authored-by: Tomasz Nastaly <[email protected]> * [ACS-7600] fix imports in dropdown widget * [ACS-7600] fix Hold interface and documentation * [ACS-7600] fix hold interfaces and documentation * [ACS-7600] fix hold interfaces and documentation * [ACS-7600] fix hold interfaces and documentation * [ACS-7600] fix hold interfaces and documentation * [ACS-7600] fix hold interfaces and documentation * [ACS-7600] fix hold interfaces and documentation --------- Co-authored-by: Darya Blavanovich <[email protected]> Co-authored-by: DaryaBalvanovich <[email protected]> Co-authored-by: tomson <[email protected]> Co-authored-by: g-jaskowski <[email protected]>

* ACS-8055 add listAssignedHolds API * ACS-8055 create legal-hold service * ACS-8055 add documentation * ACS-8055 fix imports * ACS-8055 clean up code * ACS-8055 fix interface typo * ACS-8055 add optional options and uodate nodes-api.service.md * ACS-8055 update interface * ACS-8055 add HoldPaging class and documentation * ACS-8055 add interface and fix test * ACS-8055 add documentation for legal hold service * ACS-8055 update legal-hold.service.md * ACS-8055 update legal-hold.service.md * ACS-8055 update readme file * ACS-8055 add translation --------- Co-authored-by: DaryaBalvanovich <[email protected]>

* [ACS-8055] Integrate endpoint for getting Legal Holds (#9771) * ACS-8055 add listAssignedHolds API * ACS-8055 create legal-hold service * ACS-8055 add documentation * ACS-8055 fix imports * ACS-8055 clean up code * ACS-8055 fix interface typo * ACS-8055 add optional options and uodate nodes-api.service.md * ACS-8055 update interface * ACS-8055 add HoldPaging class and documentation * ACS-8055 add interface and fix test * ACS-8055 add documentation for legal hold service * ACS-8055 update legal-hold.service.md * ACS-8055 update legal-hold.service.md * ACS-8055 update readme file * ACS-8055 add translation --------- Co-authored-by: DaryaBalvanovich <[email protected]> * ACS-7689 Save and delete to existing hold (#9841) * [ACS-7690] Saving adding o a new hold (#9862) * ACS-7689 Save and delete to existing hold * ACS-7689 Save and delete to existing hold, cleanup * ACS-7689 Save and delete to existing hold, revert to separate methods * ACS-7689 Save and delete to existing hold, fix specs * ACS-7689 Save and delete to existing hold, fix specs * ACS-7689 Save and delete to existing hold * ACS-8055 add listAssignedHolds API * ACS-8055 create legal-hold service * ACS-8055 add documentation * ACS-8055 fix imports * ACS-8055 add HoldPaging class and documentation * ACS-8055 add interface and fix test * ACS-7689 Save and delete to existing hold, fix specs * ACS-7689 Save and delete to existing hold, fix specs * ACS-7690 integrate create and assign holds endpoints * ACS-7690 fix imports * ACS-7690 add bulk method * ACS-7690 update readme file * ACS-7690 add tests * ACS-7690 update docs file * ACS-7690 remove interface * ACS-7690 update geHolds description and md file with createHold * ACS-7690 add createHolds to md file * ACS-7690 fix typo in spec, and description in legal-hold service * ACS-7690 refactor create hold parameter and documentation * ACS-7690 fixed test * ACS-7690 fix test for getHolds * ACS-7690 fix md for create hold action * ACS-7690 fix rebase conflicts --------- Co-authored-by: Tomasz Nastaly <[email protected]> Co-authored-by: DaryaBalvanovich <[email protected]> * ACS-7689 Update payload with hold id (#9877) * ACS-7600 fix documentation and method name * ACS-7600 create separate type for hold creation * [ACS-8036] [FE] Legal Hold in ADW. Part 2 (Bulk) (#10062) * ACS-8329 Manage bulks endpoint (#9972) * ACS-8325 extend ContentActionRef with tooltip (#9998) * [ACS-8425] Add functionality to select folder and assign it to a hold (#10011) * ACS-8425 add bulkFolderHold method * ACS-8425 refactor names and add more specific query to folder * ACS-8425 refactor names * ACS-8425 fix description in md file * ACS-8425 update interfaces and add constant * ACS-8425 fix readme file and refactor tests * ACS-8425 fix readme * ACS-8425 fix readme * ACS-8036 fix import path --------- Co-authored-by: Tomasz Nastaly <[email protected]> * [ACS-7600] fix imports in dropdown widget * [ACS-7600] fix Hold interface and documentation * [ACS-7600] fix hold interfaces and documentation * [ACS-7600] fix hold interfaces and documentation * [ACS-7600] fix hold interfaces and documentation * [ACS-7600] fix hold interfaces and documentation * [ACS-7600] fix hold interfaces and documentation * [ACS-7600] fix hold interfaces and documentation --------- Co-authored-by: Darya Blavanovich <[email protected]> Co-authored-by: DaryaBalvanovich <[email protected]> Co-authored-by: tomson <[email protected]> Co-authored-by: g-jaskowski <[email protected]>

DaryaBalvanovich force-pushed the ACS-8055-integrate-endpoint-for-getting-legal-holds branch 2 times, most recently from 17a291a to c3247e1 Compare June 11, 2024 21:52

DaryaBalvanovich marked this pull request as ready for review June 11, 2024 21:52

DaryaBalvanovich requested review from eromano, popovicsandras and DenysVuika as code owners June 11, 2024 21:52

MichalKinas requested changes Jun 12, 2024

View reviewed changes

DaryaBalvanovich marked this pull request as draft June 12, 2024 09:55

DaryaBalvanovich added A/N BDU labels Jun 12, 2024

DaryaBalvanovich requested a review from MichalKinas June 13, 2024 14:23

MichalKinas reviewed Jun 14, 2024

View reviewed changes

DaryaBalvanovich force-pushed the ACS-8055-integrate-endpoint-for-getting-legal-holds branch from 1588405 to 2dee84e Compare June 17, 2024 19:39

DaryaBalvanovich requested a review from MichalKinas June 17, 2024 22:49

DaryaBalvanovich marked this pull request as ready for review June 17, 2024 22:52

DaryaBalvanovich changed the base branch from develop to ACS-7600-manage-holds-base June 17, 2024 23:48

MichalKinas approved these changes Jun 18, 2024

View reviewed changes

tomson7777 reviewed Jun 18, 2024

View reviewed changes

lib/content-services/src/lib/common/services/nodes-api.service.ts Outdated Show resolved Hide resolved

tomson7777 reviewed Jun 18, 2024

View reviewed changes

lib/content-services/src/lib/legal-hold/services/legal-hold.service.ts Show resolved Hide resolved

tomson7777 reviewed Jun 18, 2024

View reviewed changes

lib/content-services/src/lib/legal-hold/services/legal-hold.service.ts Outdated Show resolved Hide resolved

tomson7777 reviewed Jun 18, 2024

View reviewed changes

lib/js-api/src/api/gs-core-rest-api/model/hold.ts Show resolved Hide resolved

AleksanderSklorz reviewed Jun 18, 2024

View reviewed changes

lib/content-services/src/lib/legal-hold/services/legal-hold.service.ts Outdated Show resolved Hide resolved

AleksanderSklorz reviewed Jun 18, 2024

View reviewed changes

lib/js-api/src/api/gs-core-rest-api/api/legal-hold.api.ts Outdated Show resolved Hide resolved

AleksanderSklorz reviewed Jun 18, 2024

View reviewed changes

lib/content-services/src/lib/legal-hold/services/legal-hold.service.ts Show resolved Hide resolved

DaryaBalvanovich added 4 commits June 18, 2024 10:57

ACS-8055 add listAssignedHolds API

2f133a2

ACS-8055 create legal-hold service

f2be4c0

ACS-8055 add documentation

a30dacd

ACS-8055 fix imports

092b436

ACS-8055 update legal-hold.service.md

5d590be

DaryaBalvanovich requested a review from AleksanderSklorz June 19, 2024 09:11

ACS-8055 update legal-hold.service.md

a43a274

AleksanderSklorz reviewed Jun 19, 2024

View reviewed changes

docs/content-services/services/legal-hold.service.md Outdated Show resolved Hide resolved

ACS-8055 update readme file

4290ac0

AleksanderSklorz approved these changes Jun 19, 2024

View reviewed changes

tomson7777 approved these changes Jun 19, 2024

View reviewed changes

ACS-8055 add translation

2822d4b

DaryaBalvanovich merged commit f2f42c6 into ACS-7600-manage-holds-base Jun 19, 2024
2 checks passed

DaryaBalvanovich deleted the ACS-8055-integrate-endpoint-for-getting-legal-holds branch June 19, 2024 18:59

DaryaBalvanovich mentioned this pull request Jun 24, 2024

ACS-7689 Save and delete to existing hold #9841

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[ACS-8055] Integrate endpoint for getting Legal Holds #9771

[ACS-8055] Integrate endpoint for getting Legal Holds #9771

DaryaBalvanovich commented Jun 5, 2024 •

edited

Loading

MichalKinas commented Jun 12, 2024

AleksanderSklorz commented Jun 18, 2024

sonarqubecloud bot commented Jun 19, 2024

[ACS-8055] Integrate endpoint for getting Legal Holds #9771

[ACS-8055] Integrate endpoint for getting Legal Holds #9771

Conversation

DaryaBalvanovich commented Jun 5, 2024 • edited Loading

MichalKinas commented Jun 12, 2024

AleksanderSklorz commented Jun 18, 2024

sonarqubecloud bot commented Jun 19, 2024

Quality Gate passed

DaryaBalvanovich commented Jun 5, 2024 •

edited

Loading