Faster Triangulated Grid Generation #131
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR speeds up
triangulated_grid
generation by around x20 what it was previously and also adds support forPoint3{Float32}
. The order of the points is preserved from the original but the order of the triangles has changed so that they are added left to right and bottom to top.The main gain in the speed here was using the order of the triangles to speed up the orientation generation significantly. The bottleneck now is the
glue_triangle
section which if improved could lead to another magnitude of speedups.Below are rough benchmarks run on my local machine.