-
Notifications
You must be signed in to change notification settings - Fork 601
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated ios min deployment target to 11 for xcode 14.3 support. #361
Conversation
@adamsousa : there are more places this needs to be updated. i.e. podspec, podfile etc. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we help this good man (@adamsousa) to merge the PR?
Using his commit from the forked branch has been the only way I've found to recompile the OHHTTPStubs with Carthage in Xcode 14.3.1.
Here you can see the error (left) and success (right) terminal logs.
This was the error log from Carthage.
Regarding People using CocaPods, perhaps you can suggest which pod-related file lines must be changed or send a PR to https://github.com/adamsousa/OHHTTPStubs/tree/xcode-14.3.
@kishorepran, could you create a PR towards https://github.com/adamsousa/OHHTTPStubs/tree/xcode-14.3 with the CocoaPods files pending to set the min target to iOS 11? |
Thank you all for your work and sorry I could not look into this sooner. So we're stuck here because I do not have the rights to bypass the required CI step that does not seem to run. I've gathered all the bumping changes in this branch and I will try to reach @AliSoftware to see if I can get the administrator rights on this. Let's hope that this is resolved soon 🤞 |
Sorry for the huge delay on this.
@Liquidsoul I'd have been happy to give you admin permissions, but it seems GitHub doesn't have an option to give administrator access to a repo if it's a personal repo and not in a Team Organization 😞
@Liquidsoul Can you help make this PR ready for merge, by ensuring that all the necessary parts are updated (especially not just the Xcode project settings like now, but also the As for CI being broken, this will need separate work—I'm thinking at migrating away from travis and switch to something like GitHub Actions, but not sure when I'll have the bandwidth tbh. |
…mple projects to target ios 11.
@AliSoftware I updated my PR with podfile and .podspec targeting iOS 11. Also updated the example projects. |
@AliSoftware : you can give me collaborator access. in that way I can help raise a pr that migrates from CI to GitHub actions. I have done this for many projects. Thanks. Also
|
Package.Swift update missing. need to update that as well. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need to cover the case for package.swift as well.
@kishorepran Added |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good to go now.
I miss a bump in tvOS deployment version as its minimal version is tvOS 11 in Xcode 14.X |
Hi @AliSoftware @Liquidsoul, is there any chance of merging this PR? |
Checklist
Description
Updated iOS deployment target to iOS 11, minimum supported in Xcode 14.3
Motivation and Context
Allows framework to be built using xcode 14.3