Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated ios min deployment target to 11 for xcode 14.3 support. #361

Merged
merged 4 commits into from
Mar 7, 2024

Conversation

adamsousa
Copy link
Contributor

@adamsousa adamsousa commented Jun 8, 2023

Checklist

  • I've checked that all new and existing tests pass
  • I've updated the documentation if necessary
  • I've added an entry in the CHANGELOG to credit myself

Description

Updated iOS deployment target to iOS 11, minimum supported in Xcode 14.3

Motivation and Context

Allows framework to be built using xcode 14.3

@kishorepran
Copy link

@adamsousa : there are more places this needs to be updated. i.e. podspec, podfile etc.

Copy link

@MagFer MagFer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we help this good man (@adamsousa) to merge the PR?

Using his commit from the forked branch has been the only way I've found to recompile the OHHTTPStubs with Carthage in Xcode 14.3.1.

image

Here you can see the error (left) and success (right) terminal logs.

image

This was the error log from Carthage.

255984453-b4b797fd-eeb1-4dd4-b338-36681e626a76

Regarding People using CocaPods, perhaps you can suggest which pod-related file lines must be changed or send a PR to https://github.com/adamsousa/OHHTTPStubs/tree/xcode-14.3.

@MagFer
Copy link

MagFer commented Jul 25, 2023

@kishorepran, could you create a PR towards https://github.com/adamsousa/OHHTTPStubs/tree/xcode-14.3 with the CocoaPods files pending to set the min target to iOS 11?

@Liquidsoul
Copy link
Collaborator

Thank you all for your work and sorry I could not look into this sooner.

So we're stuck here because I do not have the rights to bypass the required CI step that does not seem to run.

I've gathered all the bumping changes in this branch and I will try to reach @AliSoftware to see if I can get the administrator rights on this. Let's hope that this is resolved soon 🤞

@AliSoftware
Copy link
Owner

AliSoftware commented Jan 11, 2024

Sorry for the huge delay on this.

see if I can get the administrator rights on this

@Liquidsoul I'd have been happy to give you admin permissions, but it seems GitHub doesn't have an option to give administrator access to a repo if it's a personal repo and not in a Team Organization 😞

there are more places this needs to be updated. i.e. podspec, podfile etc.

@Liquidsoul Can you help make this PR ready for merge, by ensuring that all the necessary parts are updated (especially not just the Xcode project settings like now, but also the .podspec)? Or maybe just open a PR for your branch that already contains everything needed? Once it's ready, I'll come back to admin-merge, to bypass the broken CI.

As for CI being broken, this will need separate work—I'm thinking at migrating away from travis and switch to something like GitHub Actions, but not sure when I'll have the bandwidth tbh.

@adamsousa
Copy link
Contributor Author

@AliSoftware I updated my PR with podfile and .podspec targeting iOS 11. Also updated the example projects.

@kishorepran
Copy link

kishorepran commented Jan 11, 2024

@AliSoftware : you can give me collaborator access. in that way I can help raise a pr that migrates from CI to GitHub actions. I have done this for many projects. Thanks.

https://docs.github.com/en/issues/planning-and-tracking-with-projects/managing-your-project/managing-access-to-your-projects

Also

  1. I want to close the list of issues and bugs that are not relevant anymore by reaching out to people and asking them to re-open this issue if this still relevant.
  2. Support with xcprivacy.manifest and 3rd party signature management if needed from xcode 15.

@kishorepran
Copy link

@AliSoftware I updated my PR with podfile and .podspec targeting iOS 11. Also updated the example projects.

Package.Swift update missing. need to update that as well.

Copy link

@kishorepran kishorepran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to cover the case for package.swift as well.

@adamsousa
Copy link
Contributor Author

adamsousa commented Jan 11, 2024

@kishorepran Added

Copy link

@kishorepran kishorepran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good to go now.

@kikeenrique
Copy link
Contributor

I miss a bump in tvOS deployment version as its minimal version is tvOS 11 in Xcode 14.X
At least for SPM (check for reference my PR #352)

@arjankowski
Copy link

Hi @AliSoftware @Liquidsoul, is there any chance of merging this PR?

@Liquidsoul Liquidsoul merged commit c582400 into AliSoftware:master Mar 7, 2024
@adamsousa adamsousa deleted the xcode-14.3 branch March 8, 2024 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants