TPC: Add sampling to DCAr calculation, optional pT selection and DCAr vs p…

[makor]

…T, NCls, eta plots.

[wiechula]

I propose a few changes, and we need to clarify the pt cut.

[wiechula]

Thanks for the updates.

[alibuild]

Error while checking build/O2/fullCI for 5bffc2a at 2023-11-15 12:30:

## sw/BUILD/O2-latest/log
c++: error: unrecognized command-line option '--rtlib=compiler-rt'
c++: error: unrecognized command-line option '--rtlib=compiler-rt'
c++: error: unrecognized command-line option '--rtlib=compiler-rt'
c++: error: unrecognized command-line option '--rtlib=compiler-rt'


## sw/BUILD/O2Physics-latest/log
c++: error: unrecognized command-line option '--rtlib=compiler-rt'
c++: error: unrecognized command-line option '--rtlib=compiler-rt'
c++: error: unrecognized command-line option '--rtlib=compiler-rt'
c++: error: unrecognized command-line option '--rtlib=compiler-rt'


## sw/BUILD/QualityControl-latest/log
c++: error: unrecognized command-line option '--rtlib=compiler-rt'
c++: error: unrecognized command-line option '--rtlib=compiler-rt'
c++: error: unrecognized command-line option '--rtlib=compiler-rt'
c++: error: unrecognized command-line option '--rtlib=compiler-rt'


## sw/BUILD/O2-full-system-test-latest/log
Detected critical problem in logfile reco_NOGPU.log
[48242:BadMapCalibSpec]: [11:29:32][ERROR] Insufficient statistics: 9 entries in lowE histo, do nothing
[48300:ctf-writer]: [11:29:34][ERROR] Some Lifetime::Timeframe data got dropped starting at 1
[ERROR] pid 48343 (qc-task-TPC-Tracks) crashed with or was killed with exit code 1
[ERROR]  - Device qc-task-TPC-Tracks: pid 48343 (exit 1)
[ERROR] SEVERE: Device qc-task-TPC-Tracks (48343) returned with 1


## sw/BUILD/o2checkcode-latest/log
--
========== List of errors found ==========
++ GRERR=0
++ grep -v clang-diagnostic-error error-log.txt
++ grep ' error:'
++ GRERR=1
++ [[ 1 == 0 ]]
++ mkdir -p /sw/INSTALLROOT/a46068ead7fd83bd8a6ab15898049d9db75c58b9/slc8_x86-64/o2checkcode/1.0-local92/etc/modulefiles
++ cat
--

Full log here.

[wiechula]

@makor , can you please rebase on dev and force push again.

[alibuild]

Error while checking build/O2/fullCI for ef386d8 at 2023-11-20 05:33:

## sw/BUILD/O2-latest/log
c++: error: unrecognized command-line option '--rtlib=compiler-rt'
c++: error: unrecognized command-line option '--rtlib=compiler-rt'
c++: error: unrecognized command-line option '--rtlib=compiler-rt'
c++: error: unrecognized command-line option '--rtlib=compiler-rt'


## sw/BUILD/O2Physics-latest/log
c++: error: unrecognized command-line option '--rtlib=compiler-rt'
c++: error: unrecognized command-line option '--rtlib=compiler-rt'
c++: error: unrecognized command-line option '--rtlib=compiler-rt'
c++: error: unrecognized command-line option '--rtlib=compiler-rt'


## sw/BUILD/QualityControl-latest/log
c++: error: unrecognized command-line option '--rtlib=compiler-rt'
c++: error: unrecognized command-line option '--rtlib=compiler-rt'
c++: error: unrecognized command-line option '--rtlib=compiler-rt'
c++: error: unrecognized command-line option '--rtlib=compiler-rt'


## sw/BUILD/O2-full-system-test-latest/log
Detected critical problem in logfile reco_NOGPU.log
[70280:internal-dpl-ccdb-backend]: Error in <TNetXNGFile::Open>: [ERROR] Server responded with an error: [3011] No servers are available to read the file.
[70303:BadMapCalibSpec]: [04:33:15][ERROR] Insufficient statistics: 6 entries in lowE histo, do nothing
[70459:ctf-writer]: [04:33:19][ERROR] Some Lifetime::Timeframe data got dropped starting at 1
[ERROR] pid 70745 (qc-task-TPC-Tracks) crashed with or was killed with exit code 1
[ERROR]  - Device qc-task-TPC-Tracks: pid 70745 (exit 1)
[ERROR] SEVERE: Device qc-task-TPC-Tracks (70745) returned with 1


## sw/BUILD/o2checkcode-latest/log
--
========== List of errors found ==========
++ GRERR=0
++ grep -v clang-diagnostic-error error-log.txt
++ grep ' error:'
++ GRERR=1
++ [[ 1 == 0 ]]
++ mkdir -p /sw/INSTALLROOT/5ee56b608f67e8ba9ad4b9a79f72e657d683c533/slc8_x86-64/o2checkcode/1.0-local98/etc/modulefiles
++ cat
--

Full log here.

[wiechula]

@davidrohr , @makor , the crash could be real:

[67674:qc-task-TPC-Tracks]:     /sw/slc8_x86-64/O2/12149-slc8_x86-64-local2/lib/libO2TPCQC.so: o2::tpc::qc::Tracks::resetHistograms()
[67674:qc-task-TPC-Tracks]:     o2-qc() [0x41e257]:     std::vector<o2::framework::ChannelConfigurationPolicy, std::allocator<o2::framework::ChannelConfigurationPolicy> >::~vector() at stl_vector.h:730

Or are there similar problems in other tests? @davidrohr , is it possible to try to reproduce this locally? How is the fullCI run?

[davidrohr]

@wiechula : The fullCI is run in the slc8-gpu-builder docker container.
Just do aliBuild build O2FullCI or O2-full-system-test

[makor]

Thanks for the command, I will try it locally.

[makor]

@davidrohr I see that I need to connect to gitlab and download some repos (i.e. TpcFecUtils), do I need some special permissions to do it?

[makor]

I ran the building of the CI locally, however, I now obtain this error message:
`Suppressed 7022 warnings (7022 in non-user code).
Use -header-filter=.* to display errors from all non-system headers. Use -system-headers to display errors from system headers as well.
/home/max/alice/sw/ubuntu2204_x86-64/o2codechecker/v15.0-local1/bin/O2codecheck -header-filter=.SOURCES(?!./3rdparty/).* -checks=-,aliceO2-member-name,aliceO2-namespace-naming,modernize-avoid-bind,modernize-deprecated-headers,modernize-make-shared,modernize-raw-string-literal,modernize-redundant-void-arg,modernize-replace-auto-ptr,modernize-replace-random-shuffle,modernize-shrink-to-fit,modernize-unary-static-assert,modernize-use-equals-default,modernize-use-noexcept,modernize-use-nullptr,modernize-use-override,modernize-use-transparent-functors,modernize-use-uncaught-exceptions,readability-braces-around-statements -p=/home/max/alice/sw/BUILD/32b74921905e5ba12f001c508f780408c09dd89d/o2checkcode /home/max/alice/O2/run/checkStack.cxx
/home/max/alice/sw/ubuntu2204_x86-64/o2codechecker/v15.0-local1/bin/O2codecheck -header-filter=.SOURCES(?!./3rdparty/). -checks=-*,aliceO2-member-name,aliceO2-namespace-naming,modernize-avoid-bind,modernize-deprecated-headers,modernize-make-shared,modernize-raw-string-literal,modernize-redundant-void-arg,modernize-replace-auto-ptr,modernize-replace-random-shuffle,modernize-shrink-to-fit,modernize-unary-static-assert,modernize-use-equals-default,modernize-use-noexcept,modernize-use-nullptr,modernize-use-override,modernize-use-transparent-functors,modernize-use-uncaught-exceptions,readability-braces-around-statements -p=/home/max/alice/sw/BUILD/32b74921905e5ba12f001c508f780408c09dd89d/o2checkcode /home/max/alice/O2/Common/Utils/src/fpu.cxx
++ sed -e 's/ warning:/ error:/g' error-log.txt
++ mv error-log.txt.0 error-log.txt
++ echo

++ echo

++ echo '========== List of errors found =========='
========== List of errors found ==========
++ GRERR=0
++ grep -v clang-diagnostic-error error-log.txt
++ grep ' error:'
/home/max/alice/sw/SOURCES/O2/dev/0/GPU/GPUTracking/display/GPUDisplayGUIWrapper.cxx:80:76: error: use nullptr [modernize-use-nullptr]
++ [[ 0 == 0 ]]
++ exit 1`
I will try to dig a bit deeper but it is already a bit strange to me that this error is different from the one reported by the test of the CI on the git server.

[wiechula]

Hi @davidrohr , it looks like there is no problem in the compilation, but in the simulation / reconstruction run afterwards. Could you point us to what is run there in the fullCI?

[davidrohr]

@davidrohr I see that I need to connect to gitlab and download some repos (i.e. TpcFecUtils), do I need some special permissions to do it?

Well, I think it should work with your CERN nice credentials. But I usually just disable them in the defaults (alidist/defaults-p2.sh), so I doesn't prompt for username / password.

[davidrohr]

well, I'd say the crash is real, and it crashes in the QC when running the full system test.
As I wrote above, aliBuild --defaults o2 build O2-full-system-test
For fully reproducing it, you can do it inside the slc8-gpu-builder docker container.

[makor]

@davidrohr just to be precise and avoid misunderstandings, I obtained the above by running the command aliBuild build O2FullCI or O2-full-system-test. How can I properly install and enter the docker container you mentioned? I don’t have any experience to draw from. Thanks a lot!

[alibuild]

Error while checking build/O2/fullCI for 5af035a at 2023-11-21 22:52:

## sw/BUILD/O2-latest/log
c++: error: unrecognized command-line option '--rtlib=compiler-rt'
c++: error: unrecognized command-line option '--rtlib=compiler-rt'
c++: error: unrecognized command-line option '--rtlib=compiler-rt'
c++: error: unrecognized command-line option '--rtlib=compiler-rt'


## sw/BUILD/O2Physics-latest/log
c++: error: unrecognized command-line option '--rtlib=compiler-rt'
c++: error: unrecognized command-line option '--rtlib=compiler-rt'
c++: error: unrecognized command-line option '--rtlib=compiler-rt'
c++: error: unrecognized command-line option '--rtlib=compiler-rt'


## sw/BUILD/QualityControl-latest/log
c++: error: unrecognized command-line option '--rtlib=compiler-rt'
c++: error: unrecognized command-line option '--rtlib=compiler-rt'
c++: error: unrecognized command-line option '--rtlib=compiler-rt'
c++: error: unrecognized command-line option '--rtlib=compiler-rt'


## sw/BUILD/o2checkcode-latest/log
--
========== List of errors found ==========
++ GRERR=0
++ grep -v clang-diagnostic-error error-log.txt
++ grep ' error:'
/sw/SOURCES/O2/12149-slc8_x86-64/0/Generators/src/GeneratorPythia8.cxx:459:32: error: statement should be inside braces [readability-braces-around-statements]
/sw/SOURCES/O2/12149-slc8_x86-64/0/Generators/src/GeneratorPythia8.cxx:461:32: error: statement should be inside braces [readability-braces-around-statements]
++ [[ 0 == 0 ]]
++ exit 1
--

Full log here.

[wiechula]

@davidrohr , I think the error is unrelated. From my side this can be merged now.