Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase counter before sending metric #13070

Merged
merged 3 commits into from
Apr 24, 2024
Merged

Increase counter before sending metric #13070

merged 3 commits into from
Apr 24, 2024

Conversation

jgrosseo
Copy link
Collaborator

No description provided.

@jgrosseo jgrosseo requested a review from a team as a code owner April 24, 2024 10:06
Copy link
Contributor

REQUEST FOR PRODUCTION RELEASES:
To request your PR to be included in production software, please add the corresponding labels called "async-" to your PR. Add the labels directly (if you have the permissions) or add a comment of the form (note that labels are separated by a ",")

+async-label <label1>, <label2>, !<label3> ...

This will add <label1> and <label2> and removes <label3>.

The following labels are available
async-2023-pbpb-apass3
async-2023-pbpb-apass4
async-2022-pp-apass6-2023-PbPb-apass2
async-2022-pp-apass4
async-2022-pp-apass4-accepted
async-2022-pp-apass6-2023-PbPb-apass2-accepted
async-2023-pbpb-apass3-accepted
async-2023-pbpb-apass4-accepted

@jgrosseo
Copy link
Collaborator Author

@sawenzel @ktf I think the logic was inverted. Compare also to how it is done when reading AOD where we increase the counter before sending the metric.

@ddobrigk This should fix the event counter...

@jgrosseo jgrosseo requested review from ktf and sawenzel April 24, 2024 10:08
@ktf ktf merged commit b005a9d into dev Apr 24, 2024
11 of 13 checks passed
@ktf ktf deleted the jgrosseo-patch-1 branch April 24, 2024 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants