Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QC-1160 Move to the new names for QC flags #13073

Merged
merged 1 commit into from
Apr 26, 2024

Conversation

knopers8
Copy link
Collaborator

Needs QC v1.143
The documentation will be updated in a separate PR.

Needs new QC release.
The documentation will be updated in a separate PR.
Copy link
Contributor

REQUEST FOR PRODUCTION RELEASES:
To request your PR to be included in production software, please add the corresponding labels called "async-" to your PR. Add the labels directly (if you have the permissions) or add a comment of the form (note that labels are separated by a ",")

+async-label <label1>, <label2>, !<label3> ...

This will add <label1> and <label2> and removes <label3>.

The following labels are available
async-2023-pbpb-apass3
async-2023-pbpb-apass4
async-2022-pp-apass6-2023-PbPb-apass2
async-2022-pp-apass4
async-2022-pp-apass4-accepted
async-2022-pp-apass6-2023-PbPb-apass2-accepted
async-2023-pbpb-apass3-accepted
async-2023-pbpb-apass4-accepted

@alibuild
Copy link
Collaborator

alibuild commented Apr 24, 2024

Error while checking build/O2/fullCI for be979c8 at 2024-04-25 03:38:

## sw/BUILD/O2-latest/log
c++: error: unrecognized command-line option '--rtlib=compiler-rt'
c++: error: unrecognized command-line option '--rtlib=compiler-rt'


## sw/BUILD/QualityControl-latest/log
/sw/SOURCES/QualityControl/v1.142.0/v1.142.0/Framework/include/QualityControl/Quality.h:25:10: fatal error: 'DataFormatsQualityControl/FlagReasons.h' file not found
Error: /sw/slc8_x86-64/ROOT/v6-30-01-alice4-6/bin/rootcling: compilation failure (/sw/BUILD/bd7627e77fa72f8f00fbe329666b4858e6cc8e8e/QualityControl/Framework/G__O2QualityControlTypesf338756cef_dictUmbrella.h)
ninja: build stopped: cannot make progress due to previous errors.


## sw/BUILD/o2checkcode-latest/log
--
========== List of errors found ==========
++ GRERR=0
++ grep -v clang-diagnostic-error error-log.txt
++ grep ' error:'
++ GRERR=1
++ [[ 1 == 0 ]]
++ mkdir -p /sw/INSTALLROOT/b36412b013c15501be9933d5c94438ef241c9535/slc8_x86-64/o2checkcode/1.0-local1055/etc/modulefiles
++ cat
--

Full log here.

Copy link
Collaborator

@Barthelemy Barthelemy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, I couldn't spot issues.

@Barthelemy Barthelemy merged commit 639b9b2 into AliceO2Group:dev Apr 26, 2024
14 checks passed
@knopers8 knopers8 deleted the rm-old-flag-names branch April 29, 2024 07:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants