Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[O2B-1092] add migration file #1313

Merged
merged 4 commits into from
Dec 20, 2023
Merged

[O2B-1092] add migration file #1313

merged 4 commits into from
Dec 20, 2023

Conversation

xsalonx
Copy link
Collaborator

@xsalonx xsalonx commented Dec 20, 2023

I have a JIRA ticket

  • branch and/or PR name(s) include(s) JIRA ID
  • issue has "Fix version" assigned
  • issue "Status" is set to "In review"
  • PR labels are selected

Notable changes for users:

  • NA

Notable changes for developers:

  • NA

Changes made to the database:

  • add migration file for data passes table creation

@xsalonx xsalonx self-assigned this Dec 20, 2023
@xsalonx xsalonx changed the base branch from main to xsalonx/O2B-1090/integration-with-monalisa December 20, 2023 13:31
@codecov Codecov
Copy link

codecov bot commented Dec 20, 2023 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (ca7eaa2) 45.36% compared to head (2ca6fa1) 45.40%.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1313      +/-   ##
==========================================
+ Coverage   45.36%   45.40%   +0.03%     
==========================================
  Files         704      705       +1     
  Lines       11165    11173       +8     
  Branches     2039     2039              
==========================================
+ Hits         5065     5073       +8     
  Misses       6100     6100

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@xsalonx xsalonx marked this pull request as ready for review December 20, 2023 14:51
@xsalonx xsalonx changed the base branch from xsalonx/O2B-1090/integration-with-monalisa to main December 20, 2023 14:56
@xsalonx xsalonx merged commit 0b799dd into main Dec 20, 2023
@xsalonx xsalonx deleted the xsalonx/O2B-1092/implement-migration-for-data-passes branch December 20, 2023 15:20
CollinPoetoehena added a commit that referenced this pull request Dec 22, 2023
@CollinPoetoehena @martinboulais
@xsalonx @mennokonijn @dependabot @graduta
Main into this branch (contains subtask 2) (#1314)
b4a63a9 
* Release 0.75.0 (#1305)

* [O2B-1092] add migration file (#1313)

* add migration file

* add model, fix outputsize type

* add typedef

* rename

* [O2B-883]: Add bold continuous/dashed line for detector quality in overview (#1293)

* Overview of runs now show quality by using a line under them in green(continous) /red(dotted)

* [O2B-1096] Fix run-overview to run-details navigation link (#1311)

* fix issue in which all run parameters were passed to the URL when navigating from run-overview to run-details

* [O2B-1097] Display environments IDs in white in envs-overview page (#1312)

* [O2B-1095] Fix log's attachment token passed parameter (#1306)

* Bump umzug from 3.4.0 to 3.5.0 (#1309)

Bumps [umzug](https://github.com/sequelize/umzug) from 3.4.0 to 3.5.0.
- [Release notes](https://github.com/sequelize/umzug/releases)
- [Changelog](https://github.com/sequelize/umzug/blob/main/CHANGELOG.md)
- [Commits](sequelize/umzug@v3.4.0...v3.5.0)

---
updated-dependencies:
- dependency-name: umzug
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Bump the dev-dependencies group with 2 updates (#1310)

Bumps the dev-dependencies group with 2 updates: [eslint](https://github.com/eslint/eslint) and [puppeteer](https://github.com/puppeteer/puppeteer).


Updates `eslint` from 8.55.0 to 8.56.0
- [Release notes](https://github.com/eslint/eslint/releases)
- [Changelog](https://github.com/eslint/eslint/blob/main/CHANGELOG.md)
- [Commits](eslint/eslint@v8.55.0...v8.56.0)

Updates `puppeteer` from 21.5.2 to 21.6.1
- [Release notes](https://github.com/puppeteer/puppeteer/releases)
- [Changelog](https://github.com/puppeteer/puppeteer/blob/main/release-please-config.json)
- [Commits](puppeteer/puppeteer@puppeteer-v21.5.2...puppeteer-v21.6.1)

---
updated-dependencies:
- dependency-name: eslint
  dependency-type: direct:development
  update-type: version-update:semver-minor
  dependency-group: dev-dependencies
- dependency-name: puppeteer
  dependency-type: direct:development
  update-type: version-update:semver-minor
  dependency-group: dev-dependencies
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: George Raduta <[email protected]>

* [O2B-926] Added switch button to overview for PHYSICS filter (#1303)

Co-authored-by: Menno Konijn <[email protected]>
Co-authored-by: George Raduta <[email protected]>

* [O2B-1085] update proto files and grpc run controller with new user struct (#1304)

---------

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: Martin Boulais <[email protected]>
Co-authored-by: xsalonx <[email protected]>
Co-authored-by: mennokonijn <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: George Raduta <[email protected]>
Co-authored-by: Menno Konijn <[email protected]>
CollinPoetoehena added a commit that referenced this pull request Jan 12, 2024
@CollinPoetoehena @martinboulais
@xsalonx @mennokonijn @dependabot @graduta
[1086] Store user starting/stopping a run in database (#1315)
ca81e7f 
* feat: add new columns to run + add migration file

* feat: add new columns to run adapter

* feat: add new run columns to typedef in the entity

* feat: add possibility to update users on run

* Main into this branch (contains subtask 2) (#1314)

* Release 0.75.0 (#1305)

* [O2B-1092] add migration file (#1313)

* add migration file

* add model, fix outputsize type

* add typedef

* rename

* [O2B-883]: Add bold continuous/dashed line for detector quality in overview (#1293)

* Overview of runs now show quality by using a line under them in green(continous) /red(dotted)

* [O2B-1096] Fix run-overview to run-details navigation link (#1311)

* fix issue in which all run parameters were passed to the URL when navigating from run-overview to run-details

* [O2B-1097] Display environments IDs in white in envs-overview page (#1312)

* [O2B-1095] Fix log's attachment token passed parameter (#1306)

* Bump umzug from 3.4.0 to 3.5.0 (#1309)

Bumps [umzug](https://github.com/sequelize/umzug) from 3.4.0 to 3.5.0.
- [Release notes](https://github.com/sequelize/umzug/releases)
- [Changelog](https://github.com/sequelize/umzug/blob/main/CHANGELOG.md)
- [Commits](sequelize/umzug@v3.4.0...v3.5.0)

---
updated-dependencies:
- dependency-name: umzug
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Bump the dev-dependencies group with 2 updates (#1310)

Bumps the dev-dependencies group with 2 updates: [eslint](https://github.com/eslint/eslint) and [puppeteer](https://github.com/puppeteer/puppeteer).


Updates `eslint` from 8.55.0 to 8.56.0
- [Release notes](https://github.com/eslint/eslint/releases)
- [Changelog](https://github.com/eslint/eslint/blob/main/CHANGELOG.md)
- [Commits](eslint/eslint@v8.55.0...v8.56.0)

Updates `puppeteer` from 21.5.2 to 21.6.1
- [Release notes](https://github.com/puppeteer/puppeteer/releases)
- [Changelog](https://github.com/puppeteer/puppeteer/blob/main/release-please-config.json)
- [Commits](puppeteer/puppeteer@puppeteer-v21.5.2...puppeteer-v21.6.1)

---
updated-dependencies:
- dependency-name: eslint
  dependency-type: direct:development
  update-type: version-update:semver-minor
  dependency-group: dev-dependencies
- dependency-name: puppeteer
  dependency-type: direct:development
  update-type: version-update:semver-minor
  dependency-group: dev-dependencies
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: George Raduta <[email protected]>

* [O2B-926] Added switch button to overview for PHYSICS filter (#1303)

Co-authored-by: Menno Konijn <[email protected]>
Co-authored-by: George Raduta <[email protected]>

* [O2B-1085] update proto files and grpc run controller with new user struct (#1304)

---------

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: Martin Boulais <[email protected]>
Co-authored-by: xsalonx <[email protected]>
Co-authored-by: mennokonijn <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: George Raduta <[email protected]>
Co-authored-by: Menno Konijn <[email protected]>

* feat: updating user with grpc working, but with postman error

* fix: fix error with gRPC expected Run

* feat: add users from grpc to run create function

* test: add tests for runservice changes

* refactor: implement comments on pr

* fix: resolve problems occuring with naming after changes

* refactor: factorize runservice user start and stop handling

* refactor: implement comments on PR

* refactor: implement new comments on PR

* refactor: implement requested changes

* refactor: implement last request

---------

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: Martin Boulais <[email protected]>
Co-authored-by: xsalonx <[email protected]>
Co-authored-by: mennokonijn <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: George Raduta <[email protected]>
Co-authored-by: Menno Konijn <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@martinboulais martinboulais martinboulais approved these changes

@graduta graduta Awaiting requested review from graduta graduta is a code owner

Assignees

@xsalonx xsalonx

Labels
backend DB
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@xsalonx @martinboulais