[O2B-484] Fix C++ integration by bringing back runQuality to EndRun DTO #514
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
awegrzyn
referenced
this pull request
Feb 16, 2022
* Ending a run should not add a quality anymore * Adds a new `UpdateRunDto` which for now checks only on `runQuality` * Adds a new use case: `UpdateRun`
graduta
requested changes
Feb 16, 2022
lib/domain/dtos/EndRunDto.js
Outdated
| @@ -16,6 +16,7 @@ const Joi = require('joi'); | |||
| const BodyDto = Joi.object({ | |||
| timeO2End: Joi.date(), | |||
| timeTrgEnd: Joi.date(), | |||
| runQuality: Joi.string().valid('good', 'bad', 'test', '').optional(), | |||
There was a problem hiding this comment.
runQuality should not be brought back and also empty string should not be accepted.
We can keep it here for validation and backwards compatibility but it should not be added in the EndRunUseCase
Codecov Report
@@ Coverage Diff @@
## master #514 +/- ##
=======================================
Coverage 41.62% 41.62%
=======================================
Files 234 234
Lines 4183 4183
Branches 758 758
=======================================
Hits 1741 1741
Misses 2442 2442
Continue to review full report at Codecov.
|
graduta
approved these changes
Feb 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.