Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[O2B-659] Make active columns independent of the model + refactoring #661

Merged

Conversation

martinboulais
Copy link
Collaborator

@martinboulais martinboulais commented Jul 20, 2022

I have a JIRA ticket

  • branch and/or PR name(s) include(s) JIRA ID
  • issue has "Fix version" assigned
  • issue "Status" is set to "In review"
  • PR labels are selected
  • CHANGELOG.md and database/CHANGELOG.md files were updated

@martinboulais martinboulais marked this pull request as ready for review July 20, 2022 12:32
@martinboulais martinboulais force-pushed the technical/O2B-659/make-active-columns-model-independant branch from de9c413 to b3da0da Compare July 20, 2022 12:33
@codecov
Copy link

codecov bot commented Jul 20, 2022

Codecov Report

Merging #661 (e65791c) into main (301e01d) will increase coverage by 0.12%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main     #661      +/-   ##
==========================================
+ Coverage   45.77%   45.89%   +0.12%     
==========================================
  Files         313      314       +1     
  Lines        5462     5447      -15     
  Branches     1007     1004       -3     
==========================================
  Hits         2500     2500              
+ Misses       2962     2947      -15     
Impacted Files Coverage Δ
lib/public/Model.js 0.00% <0.00%> (ø)
lib/public/components/Filters/FlpsFilter/index.js 0.00% <0.00%> (ø)
lib/public/components/Filters/LogsFilter/index.js 0.00% <0.00%> (ø)
lib/public/components/Filters/RunsFilter/index.js 0.00% <0.00%> (ø)
lib/public/utilities/frontLink.js 0.00% <0.00%> (ø)
...blic/views/Envs/ActiveColumns/envsActiveColumns.js 0.00% <0.00%> (ø)
lib/public/views/Envs/Overview/index.js 0.00% <ø> (ø)
...blic/views/Flps/ActiveColumns/flpsActiveColumns.js 0.00% <0.00%> (ø)
lib/public/views/Flps/Overview/index.js 0.00% <0.00%> (ø)
lib/public/views/Home/Overview/index.js 0.00% <ø> (ø)
... and 15 more

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@martinboulais martinboulais force-pushed the technical/O2B-659/make-active-columns-model-independant branch from b3da0da to e65791c Compare July 20, 2022 13:17
@martinboulais martinboulais merged commit 1e2f333 into main Jul 21, 2022
@martinboulais martinboulais deleted the technical/O2B-659/make-active-columns-model-independant branch July 21, 2022 05:45
@martinboulais martinboulais self-assigned this Jul 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

2 participants