Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reading FT0 recpoints for TPCtimeseries #1873

Merged
merged 1 commit into from
Feb 4, 2025

Conversation

noferini
Copy link
Collaborator

Waiting for AliceO2Group/AliceO2#13853
This is to enable FT0 recpoints reading in MC for TPC Time series

@miranov25 @ercolessi

Copy link

REQUEST FOR PRODUCTION RELEASES:
To request your PR to be included in production software, please add the corresponding labels called "async-" to your PR. Add the labels directly (if you have the permissions) or add a comment of the form (note that labels are separated by a ",")

+async-label <label1>, <label2>, !<label3> ...

This will add <label1> and <label2> and removes <label3>.

The following labels are available
async-2023-pbpb-apass4
async-2023-pp-apass4
async-2024-pp-apass1
async-2022-pp-apass7
async-2024-pp-cpass0
async-2024-PbPb-apass1
async-2024-ppRef-apass1

@noferini noferini changed the title [WIP] reading FT0 recpoints for TPCtimeseries reading FT0 recpoints for TPCtimeseries Jan 29, 2025
@noferini
Copy link
Collaborator Author

noferini commented Feb 4, 2025

sim/o2 test failing in one of TPC QC task.
It is not related to this PR.
What shall we do? Can we merge?
Cheers,
Francesco

Copy link
Collaborator

@shahor02 shahor02 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Failure is unrelated, merging.

@f3sch, I suspect the failure below is related to the recent change in the matching QC, could you check, please?

Test 83: /O2DPG/MC/run/ANCHOR/tests/test_anchor_2023_apass2_pp.sh�[0;31m -> FAILED�[0m
ERROR executing anchored simulation.
�[0;31mError found in log /sw/BUILD/38cb749651fd292f269bc6dc0684a97393bb17b1/O2DPG-sim-tests/o2dpg-sim_tests/o2dpg_tests/anchored/83_test_anchor_2023_apass2_pp.sh_dir/tf1/ITSTPCmatchQC_local1.log�[0m
290-[15917:qc-task-GLO-MatchTrITSTPC]: [02:02:02][INFO] Loaded 440 params from $(O2_ROOT)/share/Common/maps/sol5k.txt
--
297-[15917:qc-task-GLO-MatchTrITSTPC]: 2025-02-04 02:02:02.906931     The objects validity is (1682275618063, 1738630922906), (18446744073709551615, 0), (4294967295, 0)
298-[15917:qc-task-GLO-MatchTrITSTPC]: Info in <TROOT::TEfficiency::CheckBinning>: Histograms are not consistent: they have different bin edges
299-[15917:qc-task-GLO-MatchTrITSTPC]: Error in <TROOT::TEfficiency::CheckConsistency>: passed TEfficiency objects have different binning
300:[15917:qc-task-GLO-MatchTrITSTPC]: [02:02:02][FATAL] Something went wrong when defining the efficiency numerator mFractionITSTPCmatchPhysPrim1OverPt_TPC from m1OverPtPhysPrimNum_TPC
301-[15917:qc-task-GLO-MatchTrITSTPC]: [02:02:02][STATE] Exiting FairMQ state machine
302:[15917:qc-task-GLO-MatchTrITSTPC]: [02:02:02][FATAL] Unhandled o2::framework::runtime_error reached the top of main of o2-qc, device shutting down. Reason: Fatal error
303-[15917:qc-task-GLO-MatchTrITSTPC]: terminate called after throwing an instance of 'o2::framework::RuntimeErrorRef'
304:[15917:qc-task-GLO-MatchTrITSTPC]: *** Program crashed (Aborted)
305-[15917:qc-task-GLO-MatchTrITSTPC]: Backtrace by DPL:

@shahor02 shahor02 merged commit 242e1b8 into AliceO2Group:master Feb 4, 2025
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants