[RecoDecay, Event Filtering, PWGHF] Revert to daughter indices using explicitly offset #668
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fgrosa
requested review from
alibuild,
ginnocen,
vkucera,
fcolamar,
a team,
jgrosseo,
iarsene and
ktf
as code owners
vkucera
approved these changes
Apr 11, 2022
jgrosseo
approved these changes
Apr 12, 2022
ChSonnabend
pushed a commit
to ChSonnabend/O2Physics
that referenced
this pull request
Apr 13, 2022
robincaron13
pushed a commit
to robincaron13/O2Physics
that referenced
this pull request
Apr 14, 2022
fgrosa
added a commit
to fgrosa/O2Physics
that referenced
this pull request
Apr 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@jgrosseo @vkucera @aalkin I am reverting this again to the indices (using the table offset explicitly for grouped tables) because of the error that I still get in analysing the MC data with @aalkin offline. In case it's helpful for debug, I can open a second PR as last time with the implementation that uses slices, let me know.
I also ping @AnnalenaKa and @strogolo who asked me about this issue last week, this PR should fix it.