Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PWGCF] FemtoUniverse -- Adding inv mass for K+K+ and K-K- #8928

Merged
merged 6 commits into from
Dec 13, 2024
Merged

[PWGCF] FemtoUniverse -- Adding inv mass for K+K+ and K-K- #8928

merged 6 commits into from
Dec 13, 2024

Conversation

zchochul
Copy link
Collaborator

No description provided.

@github-actions github-actions bot added the pwgcf label Dec 11, 2024
@github-actions github-actions bot changed the title PWGCF: FemtoUniverse -- Adding inv mass for K+K+ and K-K- [PWGCF] FemtoUniverse -- Adding inv mass for K+K+ and K-K- Dec 11, 2024
@alibuild alibuild mentioned this pull request Dec 12, 2024
Closed
@zchochul zchochul enabled auto-merge (squash) December 12, 2024 13:23
alibuild
alibuild previously approved these changes Dec 12, 2024
View reviewed changes
Copy link
Collaborator

@alibuild alibuild left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto-approving on behalf of @zchochul.

@alibuild
Copy link
Collaborator

Error while checking build/O2Physics/o2 for d5872c2 at 2024-12-12 14:38:

## sw/BUILD/O2Physics-latest/log
/sw/SOURCES/O2Physics/8928-slc9_x86-64/0/Common/TableProducer/Converters/trackQA002Converter.cxx:21:17: error: 'TracksQA_002' is not a member of 'o2::aod'; did you mean 'TracksQA_001'?
/sw/SOURCES/O2Physics/8928-slc9_x86-64/0/Common/TableProducer/Converters/trackQA002Converter.cxx:21:29: error: template argument 1 is invalid
/sw/SOURCES/O2Physics/8928-slc9_x86-64/0/Common/TableProducer/Converters/trackQA002Converter.cxx:25:32: error: 'tracksQA_000' was not declared in this scope; did you mean 'tracksQA_002'?
/sw/SOURCES/O2Physics/8928-slc9_x86-64/0/Common/TableProducer/Converters/trackQA002Converter.cxx:59:32: error: 'tracksQA_001' was not declared in this scope; did you mean 'tracksQA_002'?
ninja: build stopped: subcommand failed.

Full log here.

@zchochul zchochul disabled auto-merge December 12, 2024 13:43
@zchochul zchochul enabled auto-merge (squash) December 12, 2024 13:47
alibuild
alibuild previously approved these changes Dec 12, 2024
View reviewed changes
Copy link
Collaborator

@alibuild alibuild left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto-approving on behalf of @zchochul.

@zchochul zchochul disabled auto-merge December 13, 2024 07:22
@zchochul zchochul enabled auto-merge (squash) December 13, 2024 10:07
alibuild
alibuild previously approved these changes Dec 13, 2024
View reviewed changes
Copy link
Collaborator

@alibuild alibuild left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto-approving on behalf of @zchochul.

prchakra
prchakra previously approved these changes Dec 13, 2024
View reviewed changes
@alibuild
Copy link
Collaborator

Error while checking build/O2Physics/o2 for 3c8de8a at 2024-12-13 11:57:

## sw/BUILD/O2Physics-latest/log
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
/sw/SOURCES/O2Physics/8928-slc9_x86-64/0/PWGCF/FemtoUniverse/TableProducer/femtoUniverseProducerTask.cxx:1448:30: error: loop variable 'pdg' of type 'const uint32_t&' {aka 'const unsigned int&'} binds to a temporary constructed from type 'int' [-Werror=range-loop-construct]
/sw/SOURCES/O2Physics/8928-slc9_x86-64/0/PWGCF/FemtoUniverse/TableProducer/femtoUniverseProducerTask.cxx:1448:30: error: loop variable 'pdg' of type 'const uint32_t&' {aka 'const unsigned int&'} binds to a temporary constructed from type 'int' [-Werror=range-loop-construct]
ninja: build stopped: subcommand failed.

Full log here.

@zchochul zchochul dismissed stale reviews from prchakra and alibuild via b004001 December 13, 2024 13:14
@zchochul zchochul requested a review from prchakra December 13, 2024 14:26
@zchochul zchochul merged commit 2699fa1 into AliceO2Group:master Dec 13, 2024
9 of 11 checks passed
@vkucera
Copy link
Collaborator

vkucera commented Dec 14, 2024

@zchochul This PR introduces a compilation error. Please fix it asap.

@vkucera
Copy link
Collaborator

vkucera commented Dec 14, 2024

The macOS-arm build failed because of:

PWGCF/FemtoUniverse/Tasks/femtoUniversePairTaskTrackPhi.cxx:55:20: error: unused variable 'cutsTable' [-Werror,-Wunused-const-variable]

@vkucera vkucera mentioned this pull request Dec 14, 2024
Merged
hernasab pushed a commit to hernasab/O2Physics that referenced this pull request Dec 20, 2024
@zchochul @prchakra
[PWGCF] FemtoUniverse -- Adding inv mass for K+K+ and K-K- (AliceO2Gr…
d0b2591 
…oup#8928)

Co-authored-by: Pritam Chakraborty <[email protected]>
feisenhu pushed a commit to feisenhu/O2Physics that referenced this pull request Jan 8, 2025
@zchochul @prchakra @feisenhu
[PWGCF] FemtoUniverse -- Adding inv mass for K+K+ and K-K- (AliceO2Gr…
2a87845 
…oup#8928)

Co-authored-by: Pritam Chakraborty <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prchakra prchakra prchakra approved these changes

@alibuild alibuild alibuild left review comments

@saganatt saganatt Awaiting requested review from saganatt saganatt is a code owner

@victor-gonzalez victor-gonzalez Awaiting requested review from victor-gonzalez victor-gonzalez is a code owner

@lgraczykCern lgraczykCern Awaiting requested review from lgraczykCern lgraczykCern is a code owner

@lauraser lauraser Awaiting requested review from lauraser lauraser is a code owner

@ariedel-cern ariedel-cern Awaiting requested review from ariedel-cern ariedel-cern is a code owner

@otonvd otonvd Awaiting requested review from otonvd otonvd is a code owner

@shouqiye shouqiye Awaiting requested review from shouqiye shouqiye is a code owner

Assignees
No one assigned
Labels
pwgcf
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@zchochul @alibuild @vkucera @prchakra