Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PWGCF] Push correct task #9639

Closed
wants to merge 0 commits into from
Closed

Conversation

ilikmeta
Copy link
Contributor

No description provided.

@ilikmeta
Copy link
Contributor Author

ilikmeta commented Jan 30, 2025

Hello @victor-gonzalez please be bare with me, as I messed up the brances. Somehow, I pushed this from ilikmeta:master instead ilikmeta:origin I am sure how to push from origin. Also, for the other pull request #9620, may I close it?

@ilikmeta
Copy link
Contributor Author

ilikmeta commented Jan 30, 2025

Additionally, I test O2Linter locally, and it passed all tests. Here though is failed. I wanted to change the name of the task to flowGFWtask.cxx to apply your last comment. After O2Linter failling again, I used the name that suggested flowGfwTask.cxx I see the error depends on others tasks.

@alibuild
Copy link
Collaborator

Error while checking build/O2Physics/o2 for 8b71d0d at 2025-01-30 20:54:

## sw/BUILD/O2Physics-latest/log
/sw/SOURCES/O2Physics/9639-slc9_x86-64/0/PWGCF/Flow/Tasks/flowGFWtask.cxx:194:128: error: arithmetic between enumeration type 'FlowGFWtask::EventProgress' and floating-point type 'double' is deprecated [-Werror=deprecated-enum-float-conversion]
ninja: build stopped: subcommand failed.

Full log here.

ilikmeta added a commit to ilikmeta/O2Physics that referenced this pull request Jan 30, 2025
[PWGCF] Please consider the following formatting changes to AliceO2Group#9639
@alibuild
Copy link
Collaborator

Error while checking build/O2Physics/o2 for 8998d93 at 2025-01-30 21:37:

## sw/BUILD/O2Physics-latest/log
/sw/SOURCES/O2Physics/9639-slc9_x86-64/0/PWGCF/Flow/Tasks/flowGfwTask.cxx:194:128: error: arithmetic between enumeration type 'FlowGfwTask::EventProgress' and floating-point type 'double' is deprecated [-Werror=deprecated-enum-float-conversion]
ninja: build stopped: subcommand failed.

Full log here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

2 participants