-
Notifications
You must be signed in to change notification settings - Fork 151
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[QC-1176] Display a warning for developers if a registered object is not mergeable #2400
Conversation
For the record, we discussed in person, the agreed improvements are:
|
I think that I addressed everything that we talked about, but a bit different way. If you would prefer something else, I can do that. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, just some details to sort out, but in general the idea is good.
Do I understand correctly that the inclusion order of ObjectManager.h
and PostProcessingInterface.h
should not matter because the template is put in place after both?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks, it seems all good now!
Also marked all unwanted occurances of mergeable with ignore flag
@wiechula Can you please take a look at this PR? |
this is just a draft with an idea, how to do it compile time, I am not sure, that you like it. It does not build, it would need a bit more work. Otherwise I don't know how to do this compile time and it would need to be done run time via
dynamic_cast