Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[OGUI-1576] Object tree page download button #2719

Open
wants to merge 43 commits into
base: dev
Choose a base branch
from

Conversation

Cln89
Copy link
Collaborator

@Cln89 Cln89 commented Jan 14, 2025

I have JIRA issue created

  • branch and/or PR name(s) includes JIRA ID
  • issue has "Fix version" assigned
  • issue "Status" is set to "In review"
  • PR labels are selected
  • FLP integration tests were ran successful

This PR adds:

  • Tar was added as a node dependency for archiving root objects used for downloads in QualityControl.
  • QcDownload service to make and delete request directories for downloads and for utilizing Tar to make archives.
  • CCDB service now has download functionality for downloading root objects.
  • A download button for layouts in objectInfoResizePanel.js.

Cln89 added 30 commits November 20, 2024 17:42
Frontend:
TODO: change functionality of button to request targeted root object
Implement download button frontend for the layoutShow page

This reverts commit c4d4bcc
… download of the generated tarball to the frontend and cleanup after that
…st run and also now includes a check for the timed removal of child directories for downloads
…rom previous runs and deletes them from the filesystem.
… it no longer uses the loader as it does not support blobs
…o add download functionality to the frontend, request directories seem to be made, but end in an error in the console.
…onality originating from QcDownloadService.test.js
@@ -13,6 +13,7 @@
*/

import { LogManager, HttpServer, WebSocket } from '@aliceo2/web-ui';
import { QcDownloadService } from './lib/services/QcDownload.service.js';

Check notice

Code scanning / CodeQL

Unused variable, import, function or class Note

Unused import QcDownloadService.
@@ -15,6 +15,9 @@
import { getObjectsNameFromConsulMap } from '../../common/library/qcObject/utils.js';
import { errorHandler } from './../utils/utils.js';

const CCDB_ETAG_TEST_PRIMARY = '8cd8dfca-02fd-11ef-97e1-c0a80209250c';
const REQ_ID = '31hI8934a981438y';

Check notice

Code scanning / CodeQL

Unused variable, import, function or class Note

Unused variable REQ_ID.
@@ -15,6 +15,7 @@
/* global JSROOT */

import { RemoteData } from '/js/src/index.js';
import { jsonFetch } from './utils/jsonFetch.js';

Check notice

Code scanning / CodeQL

Unused variable, import, function or class Note

Unused import jsonFetch.
const CCDB_ETAG_TEST_PRIMARY = '8cd8dfca-02fd-11ef-97e1-c0a80209250c';
const CCDB_ETAG_TEST_SECONDARY = '426bb430-55ad-11eb-a04c-2a01cb150434';
const CCDB_ETAG_TEST_ARRAY = [CCDB_ETAG_TEST_PRIMARY, CCDB_ETAG_TEST_SECONDARY];
const CCDB_FILENAME_TEST_PRIMARY = 'TObject_1714047348446.root';

Check notice

Code scanning / CodeQL

Unused variable, import, function or class Note test

Unused variable CCDB_FILENAME_TEST_PRIMARY.
const CCDB_ETAG_TEST_SECONDARY = '426bb430-55ad-11eb-a04c-2a01cb150434';
const CCDB_ETAG_TEST_ARRAY = [CCDB_ETAG_TEST_PRIMARY, CCDB_ETAG_TEST_SECONDARY];
const CCDB_FILENAME_TEST_PRIMARY = 'TObject_1714047348446.root';
const CCDB_FILENAME_TEST_SECONDARY = 'TObject_1610548820426.root';

Check notice

Code scanning / CodeQL

Unused variable, import, function or class Note test

Unused variable CCDB_FILENAME_TEST_SECONDARY.
@Cln89 Cln89 changed the title Feature/cln89/og UI 1576/qcg object tree page download button [OGUI-1576] Object tree page download button Jan 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

1 participant