Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change filename_encoding in crypt config #5080

Closed
4 tasks done
flymin opened this issue Aug 23, 2023 · 5 comments · Fixed by #5148
Closed
4 tasks done

change filename_encoding in crypt config #5080

flymin opened this issue Aug 23, 2023 · 5 comments · Fixed by #5148
Labels
enhancement New feature or request
Milestone

Comments

@flymin
Copy link

flymin commented Aug 23, 2023

Please make sure of the following things

  • I have read the documentation.
  • I'm sure there are no duplicate issues or discussions.
  • I'm sure this feature is not implemented.
  • I'm sure it's a reasonable and popular requirement.

Description of the feature / 需求描述

Currently, filename_encoding uses base64. However, this is not supported by some old versions of rclone. For example, in Truenas scale, the default version is

rclone v1.56.1
- os/version: debian 11.5 (64 bit)
- os/kernel: 5.15.107+truenas (x86_64)
- os/type: linux
- os/arch: amd64
- go/version: go1.16.8
- go/linking: static
- go/tags: none

which does not support changing filename_encoding. Even though we can update rclone, Truenas GUI does not support such a configuration. Also, base64 is not the default choice of rclone.

Why does Alist use a different default setting? Can Alist support changing filename_encoding in the configuration?

Suggested solution / 实现思路

No response

Additional context / 附件

No response

@flymin flymin added the enhancement New feature or request label Aug 23, 2023
@welcome
Copy link

welcome bot commented Aug 23, 2023

Thanks for opening your first issue here! Be sure to follow the issue template!

@SeanHeuc
Copy link
Contributor

you can find some answers in https://alist.nn.ci/guide/drivers/Crypt.html#advanced-usage
opening a rarely used parameter in driver setting can lead to many problems/questions from many people who don't use such option.
I personally want to make the usage of crypt as simple and stupid as possible, currently alist doesnot support hide some advanced configs, if the web have such "hide" feature i'll gladly put this option in the advanced area

@flymin
Copy link
Author

flymin commented Aug 28, 2023

you can find some answers in alist.nn.ci/guide/drivers/Crypt.html#advanced-usage opening a rarely used parameter in driver setting can lead to many problems/questions from many people who don't use such option. I personally want to make the usage of crypt as simple and stupid as possible, currently alist doesnot support hide some advanced configs, if the web have such "hide" feature i'll gladly put this option in the advanced area

Sure I noted that "base64" is used as default in alist. For one thing, if you need to specifically state the default change there, it is not "a rarely used parameter". At least you are changing it every time using the rclone. For another, aligning the default settings can improve the compatibility to rclone (and also the users of TrueNAS like me). Currently, there is no way to setup alist crypt with TrueNAS Cloud Sync Tasks to survive future updates due to the mismatch of defaults in encoding type.

I think it is better to add an option with defaults as "base64" and a comment to show that it is an advanced option. Non-professionals are still able to get noticed and use "base64".

@SeanHeuc
Copy link
Contributor

SeanHeuc commented Aug 28, 2023

  1. it does is a rarely used parameter for alist users, most alist users don't use rclone crypt at all.
  2. alist crypt is currently 100% compatible with with rclone crypt. rclone and alist support different storages, it makes no sense to use rclone's default base32.

with that being said, i'll put filename_encoding in config page in next version. but please note that only default option "base64" is tested/supported.

@flymin
Copy link
Author

flymin commented Aug 28, 2023

with that being said, i'll put filename_encoding in config page in next version. but please note that only default option "base64" is tested/supported.

That will be good enough. Looking forward to the new version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
3 participants