-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update notifications from window.webkitNotifications to chrome.notifications #98
Comments
Support to `window.webkitNotifications` was not removed, it should feature check and use whatever API is available. First try to solve issue #98.
I see what you did there, can you add comments so people knows what's going on? |
Direct on the code? Here? I never updated anything on Git before, I did what I thought should be done. 2014-03-25 23:09 GMT-03:00 Braiam Peguero [email protected]:
Fábio de Godoy |
On the code, I had to read it twice to know what was going on :) 2014-03-25 22:13 GMT-04:00 mexicano21 [email protected]:
Braiam Peguero |
Just push another edit with the comments, there's no need to amend the one 2014-03-25 22:14 GMT-04:00 Braiam Peguero [email protected]:
Braiam Peguero |
All comented now. There are almost much comments as code lines now, lol. 2014-03-25 23:15 GMT-03:00 Braiam Peguero [email protected]:
Fábio de Godoy |
In Chrome 35.0.1897.2 dev-m
window.webkitNotifications
was removed, breaking the background page when the notifications are active and a new chapter is found, hence the need to update tochrome.notifications
.The text was updated successfully, but these errors were encountered: