Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update notifications from window.webkitNotifications to chrome.notifications #98

Open
mexicano21 opened this issue Mar 26, 2014 · 5 comments

Comments

@mexicano21
Copy link
Member

In Chrome 35.0.1897.2 dev-m window.webkitNotifications was removed, breaking the background page when the notifications are active and a new chapter is found, hence the need to update to chrome.notifications.

mexicano21 added a commit that referenced this issue Mar 26, 2014
Support to `window.webkitNotifications` was not removed, it should feature check and use whatever API is available. First try to solve issue #98.
@braiam
Copy link
Member

braiam commented Mar 26, 2014

I see what you did there, can you add comments so people knows what's going on?

@mexicano21
Copy link
Member Author

Direct on the code? Here?

I never updated anything on Git before, I did what I thought should be done.

2014-03-25 23:09 GMT-03:00 Braiam Peguero [email protected]:

I see what you did there, can you add comments so people knows what's
going on?

Reply to this email directly or view it on GitHubhttps://github.com//issues/98#issuecomment-38643274
.

Fábio de Godoy
http://www.animenewsnetwork.com/MyManga/?user=mexicano21

@braiam
Copy link
Member

braiam commented Mar 26, 2014

On the code, I had to read it twice to know what was going on :)

2014-03-25 22:13 GMT-04:00 mexicano21 [email protected]:

Direct on the code? Here?

I never updated anything on Git before, I did what I thought should be
done.

2014-03-25 23:09 GMT-03:00 Braiam Peguero [email protected]:

I see what you did there, can you add comments so people knows what's
going on?

Reply to this email directly or view it on GitHub<
https://github.com/AllMangasReader-dev/AMR/issues/98#issuecomment-38643274>

.

Fábio de Godoy
http://www.animenewsnetwork.com/MyManga/?user=mexicano21


Reply to this email directly or view it on GitHubhttps://github.com//issues/98#issuecomment-38643456
.

Braiam Peguero

@braiam
Copy link
Member

braiam commented Mar 26, 2014

Just push another edit with the comments, there's no need to amend the one
you did.

2014-03-25 22:14 GMT-04:00 Braiam Peguero [email protected]:

On the code, I had to read it twice to know what was going on :)

2014-03-25 22:13 GMT-04:00 mexicano21 [email protected]:

Direct on the code? Here?

I never updated anything on Git before, I did what I thought should be
done.

2014-03-25 23:09 GMT-03:00 Braiam Peguero [email protected]:

I see what you did there, can you add comments so people knows what's
going on?

Reply to this email directly or view it on GitHub<
https://github.com/AllMangasReader-dev/AMR/issues/98#issuecomment-38643274>

.

Fábio de Godoy
http://www.animenewsnetwork.com/MyManga/?user=mexicano21


Reply to this email directly or view it on GitHubhttps://github.com//issues/98#issuecomment-38643456
.

Braiam Peguero

Braiam Peguero

@mexicano21
Copy link
Member Author

All comented now. There are almost much comments as code lines now, lol.
I hope it's clear enough =)

2014-03-25 23:15 GMT-03:00 Braiam Peguero [email protected]:

Just push another edit with the comments, there's no need to amend the one
you did.

2014-03-25 22:14 GMT-04:00 Braiam Peguero [email protected]:

On the code, I had to read it twice to know what was going on :)

2014-03-25 22:13 GMT-04:00 mexicano21 [email protected]:

Direct on the code? Here?

I never updated anything on Git before, I did what I thought should be
done.

2014-03-25 23:09 GMT-03:00 Braiam Peguero [email protected]:

I see what you did there, can you add comments so people knows what's
going on?

Reply to this email directly or view it on GitHub<

https://github.com/AllMangasReader-dev/AMR/issues/98#issuecomment-38643274>

.

Fábio de Godoy
http://www.animenewsnetwork.com/MyManga/?user=mexicano21

Reply to this email directly or view it on GitHub<
https://github.com/AllMangasReader-dev/AMR/issues/98#issuecomment-38643456>

.

Braiam Peguero

Braiam Peguero

Reply to this email directly or view it on GitHubhttps://github.com//issues/98#issuecomment-38643579
.

Fábio de Godoy
http://www.animenewsnetwork.com/MyManga/?user=mexicano21

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants