-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Codegen: remove Im* prefix restriction on structs #138
Conversation
As i recall, Im* prefix means that struct kind of public and without that prefix means it's internal |
Oh, ok I see, but, since #99, we should generate everything internal, shouldn't we? |
@gucio321 Frankly, I think auto-generator should respect the public/private rule in imgui (an API is marked as private for a reason I think). If some internal API is really needed for a good reason, one could export it by hand like |
@AllenDang I see, but I think we should change this attitude for a few reasons:
Thats why I suppose we should have everything exported, notify our users, that something is not supposed to be exported in imgui (e.g. add a comment over function/type declaration or prefix it with |
Ok, you got me, let's do it, expose everything |
greate, so @AllenDang so go ahead and get it merged! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Idk why was that restriction there, but after removing it, much more function is generated