Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

backend/texture: change default texture impl #354

Merged
merged 2 commits into from
Oct 20, 2024

Conversation

gucio321
Copy link
Collaborator

now it does not free texture manually
reasons:

  • this caused a crash whenever GC was taking its fingers to the texutre. Was caused by the fact that GC runs in its own goroutine and OpenGL doesn't like it for some reason Now user needs to handle texture freeing manually

fix #350

now it does not free texture manually
reasons:
- this caused a crash whenever GC was taking its fingers to the texutre.
Was caused by the fact that GC runs in its own goroutine and OpenGL doesn't like it for some reason
Now user needs to handle texture freeing manually
@cjbrigato
Copy link

@gucio321 don't forget to release the texture in Giu. I think releasing it during cleanState is the most relevant ?

@gucio321 gucio321 merged commit 34d1e6e into AllenDang:main Oct 20, 2024
5 checks passed
@gucio321 gucio321 deleted the texture-releasing branch October 20, 2024 19:37
@gucio321
Copy link
Collaborator Author

@gucio321 don't forget to release the texture in Giu. I think releasing it during cleanState is the most relevant ?

I'll PR something soon ;-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

backend:/texture: NewTextureFromRgba causes potential crash
2 participants