[bug] Missing MouseButton function for ContextMenu on docking branch

[SeyRyuu]

What happend?

I just wanted to use the MouseButton func of the ContextMenu widget on the docking branch and noticed that this function is missing. Did the way of using the ContextMenu changed, or is this function missing in the docking branch?

The code example below works fine when using master branch instead.

Kind regards

Code example

main.go

package main

import (
	g "github.com/AllenDang/giu"
)

func main() {
	wnd := g.NewMasterWindow("Testing", 600, 400, 0)
	wnd.Run(loop)
}

func loop() {
	g.SingleWindow().Layout(
		g.Label("Click here"),

		//".MouseButton(...)" is missing
		//"g.MouseButtonLeft" can be replaced with "cimgui.ImGuiMouseButton_Left" on docking)
		g.ContextMenu().MouseButton(g.MouseButtonLeft).Layout(
			g.Label("I'm a context menu"),
		),
	)
}

To Reproduce

1. Switch to docking branch
2. Run my demo
3. Your IDE or at last your compiler will show you the missing .MouseButton(...) part

Version

docking

OS

Windows 11 x64, Ubuntu x64

[SeyRyuu]

Hey @gucio321
thanks for the quick PR to fix this issue and the migration of more stuff ^^

[SeyRyuu]

Hey @gucio321
working fine now, thank you. Also to @AllenDang for quick merging!

[SeyRyuu]

Hey @gucio321
hehe, need to go one step back ^^. I just wanted to use the ContextMenu with func .MouseButton(g.MouseButtonLeft) and it won't work with the left mouse button, you need to press the right one.

Is this problem because of these lines?
https://github.com/AllenDang/giu/pull/610/files#diff-af8cfbd7fe7309c86f3dc1bd92d3342dac333f1342117db6f14b0e9a1b4a5b33R248-R249

[gucio321]

oh, yah, sorry, forgot about changing it there 😄

[gucio321]

ugh, wait @SeyRyuu after looging at cimgui.ImGuiPopupFlags, I see that mouse button (and a few more things) are set by these flags, so you need to use them instead MouseButton()

@AllenDang should we adjust MouseButton function here and make it working with these flags, or rather remove it and let user use flags to set mouse button?

[SeyRyuu]

Hey @gucio321
thanks for the hint, using g.ContextMenu().Flags(cimgui.ImGuiPopupFlags_MouseButtonLeft) for example works fine.

But, i would say that the .MouseButton(...) fuction is the more easier way than using the flags and also the same way to change the mouse button in master-branch, but let this @AllenDang decide.

[AllenDang]

@gucio321 i think mousebutton function is better.