Font scaling (mostly for Linux) #441
Conversation
The `fontInfo` element in the loop is local, changes to its size member are not kept. BUT: The call to `.String()` for entry in the `extraFonts` map uses that size information -- yielding a key that is not reproducable. Fix: Use a local variable for the scaled size.
Codecov Report
@@ Coverage Diff @@
## master #441 +/- ##
======================================
Coverage 2.91% 2.91%
======================================
Files 30 30
Lines 3122 3121 -1
======================================
Hits 91 91
+ Misses 3031 3030 -1
Continue to review full report at Codecov.
|
|
I've really only tested on Windows. I compile giu programs on macOS and Linux, but since I do it via VirtualBox which doesn't support OpenGL, I can't see what the compiled program looks like. So I probably can't lend much wisdom here. |
|
@Necoro may I ask what is stat of this PR right now? It looks like it is draft since over a year... |
|
@gucio321 I used the my changes in my private build on Linux and Windows and it worked. But it was along the lines of "I dont really know what I'm doing". The projects I used it in where one-shot uses (more or less) and I do not use giu anymore. Therefore I've not that much motivation on porting the patch to the current HEAD. If in doubt, close this PR. The changes are rather minor and can easily be re-done by any interested party. |
|
I see. So I think it should be marked as ready-for-review. |
|
closing due to age and #628 |
DO NOT MERGE BLINDLY
As stated in #437, currently no font scaling happens on Linux, but it seems to be needed. This PR wants to look into this issue a lil' bit...
Changes in this PR:
GetContentScalealways returns 1 there)Open points so far:
style.ScaleAllSizesin MasterWindow.go#setTheme, that is only executed on Windows. Enabling this also in Linux -- shows no difference. What should I expect here?@macbutch, @HACKERALERT: As you were also dealing with DPI scaling issues (#350), do you have any input here? What platforms were you on?