Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Fixed issue with resizing events in GLFW master window" #864

Merged
merged 1 commit into from
Sep 27, 2024
Merged

Revert "Fixed issue with resizing events in GLFW master window" #864

merged 1 commit into from
Sep 27, 2024

Conversation

gucio321
Copy link
Collaborator

@gucio321 gucio321 commented Sep 27, 2024 •
edited
Loading

Reverts #831

Reasons:

  • causes state is broken #862 (giant problems with performence and overall giu functionalities)
  • I see absolutly no reason why beforeRender should be called in OnSizeChange (After fixing state mechanism, calling beforeRender in OnSizeChange doesn't help) - I'll open an issue for the problem with hube list example..

close #863, close #862

@gucio321 gucio321 mentioned this pull request Sep 27, 2024
Closed
@gucio321
Copy link
Collaborator Author

close #863, close #862

@gucio321 gucio321 merged commit e7aabec into master Sep 27, 2024
4 checks passed
@gucio321 gucio321 deleted the revert-831-glfw_render_sequence branch September 27, 2024 18:25
@gucio321 gucio321 mentioned this pull request Sep 27, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

state is broken
1 participant
@gucio321