Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Latest React update causing "unknown props" warnings #590

Closed
tylerjryan opened this issue Jul 27, 2016 · 7 comments
Closed

Latest React update causing "unknown props" warnings #590

tylerjryan opened this issue Jul 27, 2016 · 7 comments

Comments

@tylerjryan
Copy link

In the latest version of React, errors are being thrown for "unknown props". See here: https://facebook.github.io/react/warnings/unknown-prop.html

It seems that the BootstrapTable is currently throwing these (as of version 2.3.9):
screen shot 2016-07-27 at 9 59 12 am

This seems to have already been resolved by React-Bootstrap, see here: react-bootstrap/react-bootstrap#1994

I just wanted to let you know about this in case you weren't aware. Thanks for the great work!

@madeinfree
Copy link
Contributor

madeinfree commented Jul 28, 2016

Hi, @tylerjryan, about React-Bootstrap version 0.30.0 was resolved this problem, I can help to change it, Thanks !!

Edit: but must be try some test.
I try to update React-Bootstrap to version 0.30.0 but it got broken now, I'll check some reason for it.

@quantum-reference
Copy link

Yeah, I'm on 0.30.0 and the latest of react-bootstrap-table as well, and I'm still seeing this issue. Thanks for checking!

@madeinfree
Copy link
Contributor

madeinfree commented Jul 28, 2016

Hi, @tylerjryan @quantumreference I found this is issue from react-toastr module, I check that issues and have someone intent to fix it ! see Here.

@tylerjryan
Copy link
Author

perfect, that makes sense. Thank you very much!

On Wed, Jul 27, 2016 at 7:27 PM Whien [email protected] wrote:

Hi, @tylerjryan https://github.com/tylerjryan @quantumreference
https://github.com/quantumreference I found this is issue from
react-toastr module, I look at that issues and have someone to intent to
fix it ! see Here tomchentw/react-toastr#68.


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#590 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AEtDPJHwiEQZSH6K_OzOT0jqyWFKxzFeks5qaBN8gaJpZM4JWaQI
.

@AllenFang
Copy link
Owner

yes, the problem is from react-toastr

@AllenFang
Copy link
Owner

Fixed on v2.4.4. Thanks :)

@AllenFang
Copy link
Owner

there's one thing to notice, on v2.4.4 I move the css files from css to dist folder, remember to update the css path. I apologize for it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants