Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hot-fix: original metadata checks #83

Merged
merged 5 commits into from
Aug 27, 2024
Merged

hot-fix: original metadata checks #83

merged 5 commits into from
Aug 27, 2024

Conversation

helen-m-lin
Copy link
Collaborator

@helen-m-lin helen-m-lin commented Aug 27, 2024

related to #79

This PR fixes a few small issues related to _resolve_schema_information():

  • When is_in_record=True, is_in_root=False, and is_in_copy_subdir-False: get file info of new root file for the copy operation
  • When is_in_record=False, is_in_root=True, and is_in_copy_subdir-True and root file is corrupt: delete root file after copy is made
  • strip does not work for substring matching. Updated regex pattern instead
  • fixes a typo with one of the param names

@helen-m-lin helen-m-lin requested a review from jtyoung84 August 27, 2024 01:12
@helen-m-lin helen-m-lin changed the title hot-fix: hot-fix: original metadata checks Aug 27, 2024
@jtyoung84 jtyoung84 merged commit 3aae35e into main Aug 27, 2024
3 checks passed
@jtyoung84 jtyoung84 deleted the hot-fix-og-md branch August 27, 2024 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants