Add explicit default= for schema_version and describedBy fields #1102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbirman
requested review from
jtyoung84 and
dyf
and removed request for
jtyoung84
jtyoung84
approved these changes
Oct 18, 2024
dbirman
deleted the
1076-add-explicit-default-to-schema_version-to-suppress-pylance-warnings
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without this PR you get pylance warnings that there is no argument set for describedBy and schema_version when you try to create any of the core models. By setting the default the warnings go away. No tests change, but not knowing pydantic deeply I don't know if this has other consequences (I don't think it does).
Could also be that my pylance settings are junk?
closes #1076
closes #1077
Adding an image to show what the warning looks like: