Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: validate fieldnames in AindGeneric #1134

Merged
merged 4 commits into from
Nov 1, 2024

Conversation

helen-m-lin
Copy link
Contributor

closes #1133

  • Check fields in AindGeneric (including in nested lists or dictionaries) for forbidden characters.

Note: Previously this logic was in aind-data-access-api and aind-data-asset-indexer separately. There was a bug where nested lists were not checked. This is now fixed.

@helen-m-lin helen-m-lin marked this pull request as ready for review October 30, 2024 20:56
tests/test_base.py Outdated Show resolved Hide resolved
@saskiad saskiad added this pull request to the merge queue Nov 1, 2024
Merged via the queue into dev with commit 7b2a2a4 Nov 1, 2024
5 checks passed
@saskiad saskiad deleted the feat-1133-AindGeneric-validator branch November 1, 2024 04:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

is_dict_corrupt should check nested lists recursively
3 participants