Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat 3 s5 commands #4

Merged
merged 6 commits into from
Aug 8, 2024
Merged

Feat 3 s5 commands #4

merged 6 commits into from
Aug 8, 2024

Conversation

jtyoung84
Copy link
Contributor

  • Adds job to scan directories n levels deep and generates a text file manifest that can be used with s5cmd

@jtyoung84 jtyoung84 requested a review from helen-m-lin August 7, 2024 20:40
helen-m-lin
helen-m-lin requested changes Aug 7, 2024
View reviewed changes
Copy link

@helen-m-lin helen-m-lin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the final level, the for loop does not have the correct base_path.

src/aind_data_upload_utils/create_s5_commands_job.py Outdated Show resolved Hide resolved
tests/test_create_s5_commands_job.py Outdated Show resolved Hide resolved
@jtyoung84 jtyoung84 requested a review from helen-m-lin August 8, 2024 00:54
helen-m-lin
helen-m-lin approved these changes Aug 8, 2024
View reviewed changes
Copy link

@helen-m-lin helen-m-lin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@jtyoung84 jtyoung84 merged commit d218b5f into main Aug 8, 2024
1 check passed
@jtyoung84 jtyoung84 deleted the feat-3-s5-commands branch August 8, 2024 17:12
@jtyoung84 jtyoung84 mentioned this pull request Aug 8, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@helen-m-lin helen-m-lin helen-m-lin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jtyoung84 @helen-m-lin