add dummy host interface for terminal implementations #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # src/main/java/com/almostreliable/merequester/terminal/RequesterTerminalMenu.java
rlnt
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
In order for add-ons to more easily provide their own implementation of a Requester Terminal (e.g. AE2WTLib with a Wireless Requester Terminal, or Fullblock Energistics with a full-block Requester Terminal), this PR adds a common "host" interface to use for terminal implementations.
While the interface itself is effectively completely empty, due to the current part implementation itself not doing anything special (other than opening the menu which does all the heavy lifting instead), it means that the menu can be built against this host interface now rather than the specific part implementation, allowing add-ons to re-use the same menu without needing to create a duplicate Requester Terminal menu.