Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ISS-33: Fixed and expanded array functions #36

Merged
merged 4 commits into from
Aug 1, 2023
Merged

ISS-33: Fixed and expanded array functions #36

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
7e030d4
ISS-33: Fixed the array arithmetic functions and added support for of…
Alphish Jul 26, 2023
c2abd53
ISS-33: Added tests covering the large arrays and offset/length subse…
Alphish Jul 26, 2023
bd43b3e
Merge branch 'main' into bugfix/ISS-33_arraysFix
Alphish Jul 30, 2023
7574c05
ISS-33: Improved tests and handled offset/length overshooting
Alphish Jul 30, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
78 changes: 77 additions & 1 deletion Community Toolbox/scripts/tests_ArrayMaxTests/tests_ArrayMaxTests.gml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,11 @@
function ArrayMaxTests(_run, _method) : VerrificMethodTest(_run, _method) constructor {
static test_subject = "array_max";

// testing for especially large arrays,
// because original script_execute_ext(...) implementation crashed on stack overflow with ~60k items,
// so testing arrays/subsections with over ~65536 items should catch issues with naive script_execute_ext(...) implementation
static array_with_100k_items = array_create_ext(100_000, function(i) { return i; });

static should_handle_empty_array = function() {
given_array([]);
when_array_max_runs();
Expand All @@ -19,19 +24,90 @@ function ArrayMaxTests(_run, _method) : VerrificMethodTest(_run, _method) constr
then_result().should_be(10);
}

static should_handle_large_array = function() {
given_array(array_with_100k_items);
when_array_max_runs();
then_result().should_be(99_999);
}

static should_handle_offset_only = function() {
given_array([4, 6, 5, 1, 3, 2]);
given_offset(3); // should take [1, 3, 2]
when_array_max_runs();
then_result().should_be(3);
}

static should_handle_positive_offset_and_length = function() {
Alphish marked this conversation as resolved.
Show resolved Hide resolved
given_array([1, 6, 2, 7, 3, 8, 4, 9, 5, 0]);
given_offset_and_length(3, 4); // should take [7, 3, 8, 4]
when_array_max_runs();
then_result().should_be(8);
}

static should_handle_negative_offset = function() {
given_array([1, 6, 2, 7, 3, 8, 4, 9, 5, 0]);
given_offset_and_length(-5, 3); // should take [8, 4, 9]
when_array_max_runs();
then_result().should_be(9);
}

static should_handle_negative_length = function() {
given_array([1, 6, 2, 7, 3, 8, 4, 9, 5, 0]);
given_offset_and_length(5, -3); // should take [8, 3, 7]
when_array_max_runs();
then_result().should_be(8);
}

static should_handle_large_subsection = function() {
given_array(array_with_100k_items);
given_offset_and_length(20_000, 70_000); // should take [20000, 20001, ..., 89998, 89999]
when_array_max_runs();
then_result().should_be(89_999);
}

static should_handle_overshooting = function() {
given_array([1, 6, 2, 7, 3, 8, 4, 9, 5, 0]);
given_offset_and_length(7, 5); // should take [9, 5, 0]
when_array_max_runs();
then_result().should_be(9);
}

static should_handle_large_array_overshooting = function() {
given_array(array_with_100k_items);
given_offset_and_length(90_000, 20_000); // should take [90000, 90001, ..., 99998, 99999]
when_array_max_runs();
then_result().should_be(99_999);
}

// -----
// Setup
// -----

array = [];
offset = undefined;
length = undefined;
Alphish marked this conversation as resolved.
Show resolved Hide resolved
result = undefined;

static given_array = function(_array) {
array = _array;
}

static given_offset = function(_offset) {
offset = _offset;
}

static given_offset_and_length = function(_offset, _length) {
offset = _offset;
length = _length;
}

static when_array_max_runs = function() {
result = array_max(array);
if (is_undefined(offset))
result = array_max(array);
else if (is_undefined(length))
result = array_max(array, offset);
else
result = array_max(array, offset, length);
}

static then_result = function() {
Expand Down
78 changes: 77 additions & 1 deletion Community Toolbox/scripts/tests_ArrayMeanTests/tests_ArrayMeanTests.gml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,11 @@
function ArrayMeanTests(_run, _method) : VerrificMethodTest(_run, _method) constructor {
static test_subject = "array_mean";

// testing for especially large arrays,
// because original script_execute_ext(...) implementation crashed on stack overflow with ~60k items,
// so testing arrays/subsections with over ~65536 items should catch issues with naive script_execute_ext(...) implementation
static array_with_100k_items = array_create_ext(100_000, function(i) { return i; });

static should_handle_empty_array = function() {
given_array([]);
when_array_mean_runs();
Expand All @@ -19,19 +24,90 @@ function ArrayMeanTests(_run, _method) : VerrificMethodTest(_run, _method) const
then_result().should_be(3);
}

static should_handle_large_array = function() {
given_array(array_with_100k_items);
when_array_mean_runs();
then_result().should_be(49_999.5);
}

static should_handle_positive_offset_and_length = function() {
given_array([1, 6, 2, 7, 3, 8, 4, 9, 5, 0]);
given_offset_and_length(3, 4); // should take [7, 3, 8, 4]
when_array_mean_runs();
then_result().should_be(5.5);
}

static should_handle_offset_only = function() {
given_array([4, 6, 5, 1, 3, 2]);
given_offset(3); // should take [1, 3, 2]
when_array_mean_runs();
then_result().should_be(2);
}

static should_handle_negative_offset = function() {
given_array([1, 6, 2, 7, 3, 8, 4, 9, 5, 0]);
given_offset_and_length(-5, 3); // should take [8, 4, 9]
when_array_mean_runs();
then_result().should_be(7);
}

static should_handle_negative_length = function() {
given_array([1, 6, 2, 7, 3, 8, 4, 9, 5, 0]);
given_offset_and_length(5, -3); // should take [8, 3, 7]
when_array_mean_runs();
then_result().should_be(6);
}

static should_handle_large_subsection = function() {
given_array(array_with_100k_items);
given_offset_and_length(20_000, 70_000); // should take [20000, 20001, ..., 89998, 89999]
when_array_mean_runs();
then_result().should_be(54_999.5);
}

static should_handle_overshooting = function() {
given_array([1, 6, 2, 7, 3, 8, 4, 9, 5, 0]);
given_offset_and_length(7, 5); // should take [9, 5, 0]
when_array_mean_runs();
then_result().should_be(14/3);
}

static should_handle_large_array_overshooting = function() {
given_array(array_with_100k_items);
given_offset_and_length(90_000, 20_000); // should take [90000, 90001, ..., 99998, 99999]
when_array_mean_runs();
then_result().should_be(94_999.5);
}

// -----
// Setup
// -----

array = [];
offset = undefined;
length = undefined;
result = undefined;

static given_array = function(_array) {
array = _array;
}

static given_offset = function(_offset) {
offset = _offset;
}

static given_offset_and_length = function(_offset, _length) {
offset = _offset;
length = _length;
}

static when_array_mean_runs = function() {
result = array_mean(array);
if (is_undefined(offset))
result = array_mean(array);
else if (is_undefined(length))
result = array_mean(array, offset);
else
result = array_mean(array, offset, length);
}

static then_result = function() {
Expand Down
78 changes: 77 additions & 1 deletion Community Toolbox/scripts/tests_ArrayMedianTests/tests_ArrayMedianTests.gml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,11 @@
function ArrayMedianTests(_run, _method) : VerrificMethodTest(_run, _method) constructor {
static test_subject = "array_median";

// testing for especially large arrays,
// because original script_execute_ext(...) implementation crashed on stack overflow with ~60k items,
// so testing arrays/subsections with over ~65536 items should catch issues with naive script_execute_ext(...) implementation
static array_with_100k_items = array_create_ext(100_000, function(i) { return i; });

static should_handle_empty_array = function() {
given_array([]);
when_array_median_runs();
Expand All @@ -26,19 +31,90 @@ function ArrayMedianTests(_run, _method) : VerrificMethodTest(_run, _method) con
then_result().should_be(3);
}

static should_handle_large_array = function() {
given_array(array_with_100k_items);
when_array_median_runs();
then_result().should_be(50_000);
}

static should_handle_positive_offset_and_length = function() {
given_array([1, 6, 2, 7, 3, 8, 4, 9, 5, 0]);
given_offset_and_length(3, 4); // should take [7, 3, 8, 4]
when_array_median_runs();
then_result().should_be(7);
}

static should_handle_offset_only = function() {
given_array([4, 6, 5, 1, 3, 2]);
given_offset(3); // should take [1, 3, 2]
when_array_median_runs();
then_result().should_be(2);
}

static should_handle_negative_offset = function() {
given_array([1, 6, 2, 7, 3, 8, 4, 9, 5, 0]);
given_offset_and_length(-5, 3); // should take [8, 4, 9]
when_array_median_runs();
then_result().should_be(8);
}

static should_handle_negative_length = function() {
given_array([1, 6, 2, 7, 3, 8, 4, 9, 5, 0]);
given_offset_and_length(5, -3); // should take [8, 3, 7]
when_array_median_runs();
then_result().should_be(7);
}

static should_handle_large_subsection = function() {
given_array(array_with_100k_items);
given_offset_and_length(20_000, 70_000); // should take [20000, 20001, ..., 89998, 89999]
when_array_median_runs();
then_result().should_be(55_000);
}

static should_handle_overshooting = function() {
given_array([1, 6, 2, 7, 3, 8, 4, 9, 5, 0]);
given_offset_and_length(7, 5); // should take [9, 5, 0]
when_array_median_runs();
then_result().should_be(5);
}

static should_handle_large_array_overshooting = function() {
given_array(array_with_100k_items);
given_offset_and_length(90_000, 20_000); // should take [90000, 90001, ..., 99998, 99999]
when_array_median_runs();
then_result().should_be(95_000);
}

// -----
// Setup
// -----

array = [];
offset = undefined;
length = undefined;
result = undefined;

static given_array = function(_array) {
array = _array;
}

static given_offset = function(_offset) {
offset = _offset;
}

static given_offset_and_length = function(_offset, _length) {
offset = _offset;
length = _length;
}

static when_array_median_runs = function() {
result = array_median(array);
if (is_undefined(offset))
result = array_median(array);
else if (is_undefined(length))
result = array_median(array, offset);
else
result = array_median(array, offset, length);
}

static then_result = function() {
Expand Down
Loading