ISS-26: Implement array_get_random / array_pop_random (yet again) #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
First, made them return undefined instead of 0 for empty arrays/subsections. Second, fixed formatting and phrasing of the JSDocs. Also, added regions.
… because I'm pedantic
This was referenced Aug 5, 2023
Mercerenies
approved these changes
Aug 5, 2023
There was a problem hiding this comment.
Just a few real minor notes.
Testing random functions is always a pain. In principle, I'd say "mock the random number generator" and use dependency injection to test it or something, but that's massively overengineered, especially since GM doesn't really have a good concept of non-global random generators.
Community Toolbox/scripts/tests_ArrayPopRandomTests/tests_ArrayPopRandomTests.gml
Show resolved
Hide resolved
…n the source array anymore
Fixed the phrasing of the overall demo description, and also moved offset/length buttons and descriptions to have more space for array values listing.
|
👍 LGTM! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Building upon biyectivo's implementation from PR #39. Changes include: