Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accordion component | Commodore #28

Closed
AlbyIsCoding opened this issue May 30, 2022 · 0 comments · Fixed by #48
Closed

Accordion component | Commodore #28

AlbyIsCoding opened this issue May 30, 2022 · 0 comments · Fixed by #48
Assignees
Labels
team/auth Issue affecting the auth team

Comments

@AlbyIsCoding
Copy link
Contributor

AlbyIsCoding commented May 30, 2022

We need an Accordion component like the one in the picture below. The Accordion should handle x amount of elements and picture the below shows how each element should look.
image

Potential architecture (get inspiration from Radix UI Primitives https://github.com/radix-ui/primitives):

  • Accordion that's parent and has callback method onExpand
  • AccordionItem
  • AccordionContent
  • AccordionMessage (the yellow note at the bottom of the card. May be redundant if we can use Panel component for this instead)

Other stuff to think about:

  • More than one Accordion should be open at the same time on default (Lay up code so it's easy to choose between more open at once or only 1 open at the same time).
  • The arrow down symbol needs to turn from pointing to right to pointing down when clicked.
  • Card shadow
  • Background colors

Questions:

onExpand could be nullable, if no onExpand method defined card is always expanded? Should we support not having expand method?

@haakemon haakemon added the status/draft Status: When you create an issue before you have enough info to properly describe the issue. label Jun 3, 2022
@AlbyIsCoding AlbyIsCoding changed the title Sent requests list view | Commodore Sent requests accordion | Commodore Jun 15, 2022
@AlbyIsCoding AlbyIsCoding assigned AlbyIsCoding and unassigned nemzes Jun 15, 2022
@AlbyIsCoding AlbyIsCoding changed the title Sent requests accordion | Commodore Sent requests accordion component | Commodore Jun 20, 2022
@AlbyIsCoding AlbyIsCoding changed the title Sent requests accordion component | Commodore Accordion component | Commodore Aug 11, 2022
@AlbyIsCoding AlbyIsCoding added the team/auth Issue affecting the auth team label Aug 11, 2022
@sivaglen sivaglen removed the status/draft Status: When you create an issue before you have enough info to properly describe the issue. label May 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
team/auth Issue affecting the auth team
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants