-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/accordion components #48
Conversation
…nto feat/accordion-components
Had to delete a test for key press with enter because of this bug in testing library: testing-library/user-event#554 |
The issueyou linked to is closed, with a resolution in the comment testing-library/user-event#554 (comment) Please add the test back and try this. If we dont have these types of tests, we cannot guarantee the behavior, and refactoring later on may lead to bugs. We shouldnt investigate other options before just removing tests. |
The test was added back some weeks ago |
Ah, my bad 😅 looking on mobile, and didnt see this was an old comment.. Looks good now, great work 😁 |
Description
This is a controlled accordion component with optional actions in header and arrow icon that rotates 90 degrees when accordion is opened when it's clicked by mouse or space/enter.
Related Issue(s)
Verification
Documentation