Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ui-component): Add event listeners on table level #13923

Merged
merged 5 commits into from
Nov 12, 2024

Conversation

TomasEng
Copy link
Contributor

@TomasEng TomasEng commented Oct 25, 2024

Description

This pull request adds onChangeAny, onFocusAny og onBlurAny props to the StudioInputTable component. These props allow the user to listen for the corresponding event on any input element within the table without defining a listener on every element. They are going to be used as part of the validation saving functionality for code lists.

Related Issue(s)

Verification

  • Your code builds clean without any errors or warnings
  • Manual testing done (required)
  • Relevant automated test added (if you find this hard, leave it and we'll help out)

@github-actions github-actions bot added solution/studio/designer Issues related to the Altinn Studio Designer solution. frontend labels Oct 25, 2024
@TomasEng TomasEng added skip-releasenotes Issues that do not make sense to list in our release notes skip-manual-testing PRs that do not need to be tested manually skip-documentation Issues where updating documentation is not relevant labels Oct 25, 2024
Copy link

codecov bot commented Oct 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.21%. Comparing base (22337dc) to head (84b43f6).
Report is 16 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #13923   +/-   ##
=======================================
  Coverage   95.20%   95.21%           
=======================================
  Files        1740     1742    +2     
  Lines       22815    22846   +31     
  Branches     2670     2670           
=======================================
+ Hits        21722    21753   +31     
  Misses        847      847           
  Partials      246      246           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@TomasEng TomasEng changed the title feat(StudioInputTable): Add event listeners on table level feat(ui-component): Add event listeners on table level Oct 25, 2024
@TomasEng TomasEng force-pushed the input-table-event-listeners branch from d3a81c6 to e8b4208 Compare October 25, 2024 12:18
@TomasEng TomasEng marked this pull request as ready for review October 25, 2024 12:38
@TomasEng
Copy link
Contributor Author

TomasEng commented Nov 8, 2024

Closing this as this functionality is not necessary at the moment. Validation has been solved using other means.

@TomasEng TomasEng closed this Nov 8, 2024
@TomasEng
Copy link
Contributor Author

TomasEng commented Nov 8, 2024

Reopening since this will be useful for saving.

@TomasEng TomasEng reopened this Nov 8, 2024
@Konrad-Simso Konrad-Simso self-assigned this Nov 11, 2024
Copy link
Contributor

@Konrad-Simso Konrad-Simso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! 💪 Here are 2 cleanup comments

Copy link
Contributor

@Konrad-Simso Konrad-Simso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work!

@Konrad-Simso Konrad-Simso merged commit bf7450c into main Nov 12, 2024
9 checks passed
@Konrad-Simso Konrad-Simso deleted the input-table-event-listeners branch November 12, 2024 08:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
frontend skip-documentation Issues where updating documentation is not relevant skip-manual-testing PRs that do not need to be tested manually skip-releasenotes Issues that do not make sense to list in our release notes solution/studio/designer Issues related to the Altinn Studio Designer solution. team/studio-domain1
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants