-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(ui-component): Add event listeners on table level #13923
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #13923 +/- ##
=======================================
Coverage 95.20% 95.21%
=======================================
Files 1740 1742 +2
Lines 22815 22846 +31
Branches 2670 2670
=======================================
+ Hits 21722 21753 +31
Misses 847 847
Partials 246 246 ☔ View full report in Codecov by Sentry. |
d3a81c6
to
e8b4208
Compare
Closing this as this functionality is not necessary at the moment. Validation has been solved using other means. |
Reopening since this will be useful for saving. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work! 💪 Here are 2 cleanup comments
frontend/libs/studio-components/src/components/StudioInputTable/Cell/CellTextarea.tsx
Outdated
Show resolved
Hide resolved
frontend/libs/studio-pure-functions/src/StringUtils/StringUtils.test.ts
Outdated
Show resolved
Hide resolved
…e/Cell/CellTextarea.tsx Co-authored-by: Konrad-Simso <[email protected]>
…s.test.ts Co-authored-by: Konrad-Simso <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good work!
Description
This pull request adds
onChangeAny
,onFocusAny
ogonBlurAny
props to theStudioInputTable
component. These props allow the user to listen for the corresponding event on any input element within the table without defining a listener on every element. They are going to be used as part of thevalidationsaving functionality for code lists.Related Issue(s)
Verification