-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Remove featureflag multiple data models per task #14171
base: main
Are you sure you want to change the base?
Conversation
…he type for simpleBinding with InternalBindingFormat
This may need to be set to blocked after review until this is solved #14104, to make sure that number 4 works, |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #14171 +/- ##
==========================================
- Coverage 95.58% 95.57% -0.02%
==========================================
Files 1869 1869
Lines 24237 24234 -3
Branches 2786 2785 -1
==========================================
- Hits 23167 23161 -6
- Misses 814 815 +1
- Partials 256 258 +2 ☔ View full report in Codecov by Sentry. |
…//github.com/Altinn/altinn-studio into remove-featureflag-multipleDataModelsPerTask
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work! 🚀 I just left suggestions to remove some console.log
.
Thx! :) |
Tested OK in dev! 🙂🚀 but I didn’t realize I had already done the CR, so I can’t add the second approval on this one 🫤 |
Thx for testing, @Annikenkbrathen! I will investigate case 2 and your other comments 🙂 |
Description
This PR removes the feature flag:
'multipleDataModelsPerTask
and the code related to this + updates tests.What should be tested before merging this to main
Pre-Test Setup
Test cases
Default data model binding for layout set
a. Create a new layout set i prosesser
b. Bind the layout set to a default data model
c. Go to “Utforming” section and add a component
d. Verify that the default data model is selected in the data model bindings for the component.
Select an Alternative Data Model in Data Model Bindings
a. Confirm that you can select a data model other than the default in the data model bindings for a component.
Switch between data models in data model bindings
a. Test switching between different data models in the data model bindings for a component
b. Ensure the related data model fields are displayed correctly in the dropdown list for each selection.
Preview Functionality with non-default data models
a. Verify that the preview functionality works as expected when a data model other than the default is selected.
b. See releated issue: Preview Fails When Linking Component to Non-Default Data Model #14104
Layout configuration – correct bindings displayed
a. In the layout configuration in “se siste endringer”:
i. Check that the correct bindings are displayed when selecting data model fields for the default data model
ii. Check that the correct bindings are displayed when selecting a non-default data model and one of its data model fields
Related Issue(s)
Verification
Documentation