Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Code cleanup in code list editor #14258

Merged
merged 2 commits into from
Dec 12, 2024
Merged

Conversation

TomasEng
Copy link
Contributor

@TomasEng TomasEng commented Dec 11, 2024

Description

The terms "change" and "blur" are used for the same event in the code list editor, causing misinformation in the code. I have reverted the recent changes that caused this, and created a separate onBlurAny prop that is triggered by the corresponding prop on the StudioInputTable component.

Related Issues

Verification

  • Your code builds clean without any errors or warnings
  • Manual testing done (required)
  • Relevant automated test added (if you find this hard, leave it and we'll help out)

@github-actions github-actions bot added area/ui-editor Area: Related to the designer tool for assembling app UI in Altinn Studio. solution/studio/designer Issues related to the Altinn Studio Designer solution. frontend labels Dec 11, 2024
@TomasEng TomasEng force-pushed the cleanup-codelisteditor branch from 56e3469 to fb098f9 Compare December 11, 2024 08:06
@TomasEng TomasEng added quality/code Violations from current rules for code, best practices, etc. Or just bad code. team/studio-domain1 skip-releasenotes Issues that do not make sense to list in our release notes skip-documentation Issues where updating documentation is not relevant labels Dec 11, 2024
Copy link

codecov bot commented Dec 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.53%. Comparing base (37d92b5) to head (fb098f9).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #14258   +/-   ##
=======================================
  Coverage   95.52%   95.53%           
=======================================
  Files        1826     1826           
  Lines       23757    23759    +2     
  Branches     2752     2752           
=======================================
+ Hits        22695    22697    +2     
  Misses        807      807           
  Partials      255      255           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@TomasEng TomasEng marked this pull request as ready for review December 11, 2024 09:05
@Konrad-Simso Konrad-Simso self-assigned this Dec 11, 2024
Copy link
Contributor

@Konrad-Simso Konrad-Simso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work 🚀 and thank you for cleaning up my mistakes.

@Konrad-Simso Konrad-Simso removed their assignment Dec 11, 2024
@standeren standeren self-assigned this Dec 12, 2024
@TomasEng TomasEng added the skip-manual-testing PRs that do not need to be tested manually label Dec 12, 2024
@TomasEng
Copy link
Contributor Author

Setting the skip-manual-testing label here since this is just a refactor, and the functionality is behind a feture flag.

@TomasEng TomasEng merged commit 0f7b868 into main Dec 12, 2024
5 checks passed
@TomasEng TomasEng deleted the cleanup-codelisteditor branch December 12, 2024 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ui-editor Area: Related to the designer tool for assembling app UI in Altinn Studio. frontend quality/code Violations from current rules for code, best practices, etc. Or just bad code. skip-documentation Issues where updating documentation is not relevant skip-manual-testing PRs that do not need to be tested manually skip-releasenotes Issues that do not make sense to list in our release notes solution/studio/designer Issues related to the Altinn Studio Designer solution. team/studio-domain1
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

3 participants