-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: Code cleanup in code list editor #14258
Conversation
56e3469
to
fb098f9
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #14258 +/- ##
=======================================
Coverage 95.52% 95.53%
=======================================
Files 1826 1826
Lines 23757 23759 +2
Branches 2752 2752
=======================================
+ Hits 22695 22697 +2
Misses 807 807
Partials 255 255 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work 🚀 and thank you for cleaning up my mistakes.
Setting the |
Description
The terms "change" and "blur" are used for the same event in the code list editor, causing misinformation in the code. I have reverted the recent changes that caused this, and created a separate
onBlurAny
prop that is triggered by the corresponding prop on theStudioInputTable
component.Related Issues
Verification