chore: update error handling in useValidateComponent #14352
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Konrad-Simso
added
area/ui-editor
github-actions
bot
added
the
solution/studio/designer
ErlingHauan
approved these changes
Jan 6, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #14352 +/- ##
==========================================
- Coverage 95.54% 95.53% -0.01%
==========================================
Files 1860 1860
Lines 24106 24099 -7
Branches 2783 2782 -1
==========================================
- Hits 23031 23024 -7
Misses 817 817
Partials 258 258 ☔ View full report in Codecov by Sentry. |
ErlingHauan
deleted the
chore/update-error-handling-in-useValidateComponent
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Update error handling to not return an error when optionsId is set.
With the the changes made from the PRs in Dependencies, we are rendering alerts to warn the user at appropriate times. This PR will remove the double warning as it will no not serve a purpose to render both an error and an alert.
Related Issue
Verification
Dependencies
ReferenceTab.tsx#14307