fix(designer): Prevent propagation of 401 Unauthorized status from Azure DevOps #14378
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
solution/studio/designer
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
...Designer.Tests/TypedHttpClients/DelegatingHandlers/AzureDevOpsTokenDelegatingHandlerTests.cs
Dismissed
Show dismissed
Hide dismissed
...Designer.Tests/TypedHttpClients/DelegatingHandlers/AzureDevOpsTokenDelegatingHandlerTests.cs
Dismissed
Show dismissed
Hide dismissed
...Designer.Tests/TypedHttpClients/DelegatingHandlers/AzureDevOpsTokenDelegatingHandlerTests.cs
Dismissed
Show dismissed
Hide dismissed
...Designer.Tests/TypedHttpClients/DelegatingHandlers/AzureDevOpsTokenDelegatingHandlerTests.cs
Dismissed
Show dismissed
Hide dismissed
...Designer.Tests/TypedHttpClients/DelegatingHandlers/AzureDevOpsTokenDelegatingHandlerTests.cs
Dismissed
Show dismissed
Hide dismissed
...Designer.Tests/TypedHttpClients/DelegatingHandlers/AzureDevOpsTokenDelegatingHandlerTests.cs
Dismissed
Show dismissed
Hide dismissed
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #14378 +/- ##
=======================================
Coverage 95.57% 95.57%
=======================================
Files 1865 1865
Lines 24152 24152
Branches 2783 2783
=======================================
Hits 23083 23083
Misses 812 812
Partials 257 257 ☔ View full report in Codecov by Sentry. |
…tps://github.com/Altinn/altinn-studio into fix/improveErrorHandlingOfAzureDevOpsIntegration
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds the
AzureDevOpsTokenDelegatingHandlerto prevent the propagation of a401 Unauthorizedstatus from Azure DevOps. Instead, a500 Internal Server Erroris returned to ensure that401errors do not leak into the application, which cause our fronted to logout our users.Related Issue(s)
Verification