Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: clean package install in ngAdd schematics #1220

Merged
merged 1 commit into from
Feb 20, 2024
Merged

feat: clean package install in ngAdd schematics #1220

merged 1 commit into from
Feb 20, 2024

Conversation

kpanot
Copy link
Contributor

@kpanot kpanot commented Jan 16, 2024 •
edited
Loading

Proposed change

Refactor of the IT to properly test the generators.
The changes include:

  • Migration of install process to task (instead of blocking rule)
  • Based the ITs on Npm Create project
  • The environment of IT is now defined at pipeline level (as matrix)
  • Add NPM Create option to specify the version of yarn used within generated workspace

@kpanot kpanot requested a review from a team as a code owner January 16, 2024 09:29
@kpanot kpanot force-pushed the feature/clean-package-install branch from b163a96 to 4c37765 Compare January 16, 2024 09:45
@kpanot kpanot force-pushed the feature/clean-package-install branch 9 times, most recently from 55911da to 854d032 Compare January 19, 2024 09:58
@kpanot kpanot force-pushed the feature/clean-package-install branch 14 times, most recently from 5ca51c2 to bd6a274 Compare February 19, 2024 17:01
fpaul-1A
fpaul-1A previously approved these changes Feb 19, 2024
View reviewed changes
@kpanot kpanot force-pushed the feature/clean-package-install branch from bd6a274 to c6dad0d Compare February 20, 2024 01:07
fpaul-1A
fpaul-1A previously approved these changes Feb 20, 2024
View reviewed changes
@kpanot
feat: clean package install in ngAdd schematics
571938b 
feat: clean package install in ngAdd schematics

feat: migrate packageManager helpers
@kpanot kpanot dismissed stale reviews from matthieu-crouzet and fpaul-1A via 571938b February 20, 2024 13:17
@kpanot kpanot force-pushed the feature/clean-package-install branch from c6dad0d to 571938b Compare February 20, 2024 13:17
@kpanot kpanot added this pull request to the merge queue Feb 20, 2024
Merged via the queue into main with commit da3eaf7 Feb 20, 2024
27 of 28 checks passed
@kpanot kpanot deleted the feature/clean-package-install branch February 20, 2024 14:32
@vscaiceanu-1a vscaiceanu-1a mentioned this pull request Feb 29, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrednic-1A mrednic-1A mrednic-1A left review comments

@vscaiceanu-1a vscaiceanu-1a vscaiceanu-1a left review comments

@divdavem divdavem divdavem left review comments

@fpaul-1A fpaul-1A fpaul-1A approved these changes

@matthieu-crouzet matthieu-crouzet matthieu-crouzet approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request project:@ama-sdk/create project:@ama-sdk/schematics project:@o3r/analytics project:@o3r/apis-manager project:@o3r/application project:@o3r/components project:@o3r/configuration project:@o3r/core project:@o3r/create project:@o3r/design project:@o3r/dynamic-content project:@o3r/eslint-config-otter project:@o3r/eslint-plugin project:@o3r/extractors project:@o3r/forms project:@o3r/localization project:@o3r/logger project:@o3r/mobile project:@o3r/routing project:@o3r/rules-engine project:@o3r/schematics project:@o3r/showcase project:@o3r/store-sync project:@o3r/storybook project:@o3r/stylelint-plugin project:@o3r/styling project:@o3r/test-helpers project:@o3r/testing project:@o3r/third-party project:@o3r/workspace
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

The generation of project using @o3r/create should be tested
6 participants
@kpanot @divdavem @matthieu-crouzet @vscaiceanu-1a @mrednic-1A @fpaul-1A