Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(vscode): unlock vscode extension #2646

Merged
merged 2 commits into from
Jan 7, 2025

Conversation

kpanot
Copy link
Contributor

@kpanot kpanot commented Dec 23, 2024

Proposed change

Allow the VsCode extension to be loaded without espree detection
This PR is not a proper fix of the lack of espree dependency but unlock the extension run

Note: The cascading conflicts should be ignored in favor of #2647

Related issues

@kpanot kpanot requested a review from a team as a code owner December 23, 2024 03:30
@kpanot kpanot changed the base branch from main to release/11.5 December 23, 2024 03:30
@kpanot kpanot force-pushed the bugfix/vscode-deprecated-eslint-config branch from 30a3748 to 35902f6 Compare January 6, 2025 02:07
Copy link

nx-cloud bot commented Jan 6, 2025

View your CI Pipeline Execution ↗ for commit 8643504.

Command Status Duration Result
nx run-many --target=test-e2e --parallel 3 ❌ Failed 2m 55s View ↗
nx run-many --target=test-int --parallel 3 ✅ Succeeded 1s View ↗
nx run-many --target=build --projects=eslint-pl... ✅ Succeeded <1s View ↗
nx run-many --target=publish --parallel 3 --nx-... ✅ Succeeded 33s View ↗
nx affected --target=test --parallel 3 --cacheD... ✅ Succeeded <1s View ↗
nx run-many --target=build --parallel 3 ✅ Succeeded 37s View ↗
nx run ama-sdk-schematics:build-swagger ✅ Succeeded <1s View ↗
nx affected --target=test --parallel 3 --cacheD... ✅ Succeeded <1s View ↗
Additional runs (2) ✅ Succeeded ... View ↗

☁️ Nx Cloud last updated this comment at 2025-01-07 14:21:06 UTC

@github-actions github-actions bot added bug Something isn't working project:otter-devtools labels Jan 6, 2025
Copy link

codecov bot commented Jan 6, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 0.00%. Comparing base (1668f71) to head (8643504).
Report is 3 commits behind head on release/11.5.

✅ All tests successful. No failed tests found.

Additional details and impacted files

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kpanot kpanot force-pushed the bugfix/vscode-deprecated-eslint-config branch from 35902f6 to 8b359cd Compare January 6, 2025 04:17
@kpanot kpanot enabled auto-merge January 7, 2025 14:05
@kpanot kpanot merged commit 1eaf786 into release/11.5 Jan 7, 2025
26 of 28 checks passed
@kpanot kpanot deleted the bugfix/vscode-deprecated-eslint-config branch January 7, 2025 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working project:otter-devtools
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants