-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed the test cases #112
Fixed the test cases #112
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
MAKE SURE YOU'RE FORMATTING YOUR CODE.
And just a quick-fix for the file tests/test_graph.py
as this PR is related to test cases it can be get fixed too.
- You can use a single import statement for importing both
display and copy_to_clipboard
something likefrom package.graph import copy_to_clipboard, display
currently the code uses 2 different import statement. - we don't need these imports there
os, sys and shutil
as we aren't using those in that file. - That assert statement should be something like
assert display("test",current_time) is None
instead of using==
- And the last except statement should be a f-string as it complains about e is assigned but never used.
pytest.fail(f"Unexpected error raised: {e}")
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!, Approved.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Title of the Pull Request
Related Issue
closes #111
Description
I changed the test cases of
models.py
andpiechart.py
according to the new features and they are running perfectly fine.I did not work on the test cases of
graph.py
ass those test cases and features are still left to be fixed.test cases results for
model.py
test cases result
graph.py
Type of change
What sort of changes have you made:
All the test cases are working good and the issues are fixed. please review them and let me know if any changes are required.
Thank you!!
Checklist