Skip to content
This repository has been archived by the owner on Jan 29, 2025. It is now read-only.

Display: added all the features from 3 files #119

Merged
merged 10 commits into from
Oct 17, 2024
Merged

Display: added all the features from 3 files #119

merged 10 commits into from
Oct 17, 2024

Conversation

tannuiscoding
Copy link
Contributor

I have implemented the three write.py, show.py and clip.py in display.py.

@iamyaash iamyaash added gssoc-ext Issues labelled only for GSSoC'24 Extended Edition level1 Issues that are easy to fix! hacktoberfest-accepted hacktoberfest 2024 labels Oct 15, 2024
jindalpriyanshu101
jindalpriyanshu101 suggested changes Oct 16, 2024
View reviewed changes
Copy link
Member

@jindalpriyanshu101 jindalpriyanshu101 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're comparing different datatypes(string & int) as password check, fix that. i've attached 2 suggestions that you can implement to fix that.

package/clip.py Outdated Show resolved Hide resolved
package/show.py Outdated Show resolved Hide resolved
package/write.py Outdated Show resolved Hide resolved
@iamyaash iamyaash self-requested a review October 16, 2024 12:23
@jindalpriyanshu101
Copy link
Member

The time is ticking

image

@iamyaash @jindalpriyanshu101
Update package/clip.py
a181458 
Co-authored-by: Priyanshu Jindal <[email protected]>
iamyaash
iamyaash reviewed Oct 17, 2024
View reviewed changes
package/show.py Outdated Show resolved Hide resolved
iamyaash
iamyaash reviewed Oct 17, 2024
View reviewed changes
package/write.py Outdated Show resolved Hide resolved
iamyaash
iamyaash approved these changes Oct 17, 2024
View reviewed changes
Copy link
Collaborator

@iamyaash iamyaash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

display.py feature is working perfectly. I have updated the arguments to accept int instead of str.

So far, LGTM! ✅

@iamyaash
Copy link
Collaborator

fixes #77

@iamyaash iamyaash merged commit 5942f2f into AmateursLeague:main Oct 17, 2024
1 check passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jindalpriyanshu101 jindalpriyanshu101 jindalpriyanshu101 requested changes

@iamyaash iamyaash iamyaash approved these changes

Assignees

@tannuiscoding tannuiscoding

Labels
gssoc-ext Issues labelled only for GSSoC'24 Extended Edition hacktoberfest-accepted hacktoberfest 2024 level1 Issues that are easy to fix!
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tannuiscoding @jindalpriyanshu101 @iamyaash