Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Yashksaini coder/issue186 #194

Merged

Conversation

yashksaini-coder
Copy link
Contributor

@yashksaini-coder yashksaini-coder commented Nov 2, 2024

closes #186

Description

This pull request includes changes to improve password validation and correct a minor syntax error in a print statement. The most important changes include updating the password validation logic across multiple files and fixing a formatting issue in a print statement.

Password Validation Updates:

  • package/clip.py: Changed password validation to use str(password).zfill(4) instead of int(password) to ensure the password is correctly formatted as a four-digit string.
  • package/show.py: Updated password validation logic to match the new format using str(password).zfill(4).
  • package/write.py: Modified password validation to use str(password).zfill(4) for consistency and correctness.

Syntax Error Fix:

  • package/write.py: Corrected a minor syntax error in a print statement by removing an unnecessary newline character.

Type of change

What sort of changes have you made:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, local variables)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Screenshot 2024-11-02 065358

@yashksaini-coder
Copy link
Contributor Author

@this-is-yaash the current leading trail zeros error is fixed, I have shared my approach on discord, add proper labels and review this PR

Copy link
Collaborator

@iamyaash iamyaash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@iamyaash iamyaash added good first issue Good for newcomers gssoc-ext Issues labelled only for GSSoC'24 Extended Edition level1 Issues that are easy to fix! hacktoberfest-accepted hacktoberfest 2024 labels Nov 2, 2024
@iamyaash iamyaash merged commit cf77945 into AmateursLeague:main Nov 2, 2024
1 check passed
@yashksaini-coder yashksaini-coder deleted the yashksaini-coder/issue186 branch November 2, 2024 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers gssoc-ext Issues labelled only for GSSoC'24 Extended Edition hacktoberfest-accepted hacktoberfest 2024 level1 Issues that are easy to fix!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: Password validation fails when first digit is 0
2 participants