Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unwrapping on gilrs::new() #18

Closed
silverhadch opened this issue Oct 22, 2024 · 3 comments
Closed

Unwrapping on gilrs::new() #18

silverhadch opened this issue Oct 22, 2024 · 3 comments
Assignees
Labels
bug Something isn't working good first issue Good for newcomers help wanted Extra attention is needed

Comments

@silverhadch
Copy link
Contributor

The gilrs: Gilrs::new().unwrap(); could panic if the gamepad interface cannot be initialized (e.g., missing drivers or unsupported hardware).

Replace .unwrap() with a more graceful fallback, like logging the error and continuing without gamepad support.

@Amjad50 Amjad50 added bug Something isn't working help wanted Extra attention is needed good first issue Good for newcomers labels Oct 22, 2024
@inyourface34456
Copy link
Contributor

i could take this issue

@Amjad50
Copy link
Owner

Amjad50 commented Nov 2, 2024

Great, thanks @inyourface34456

inyourface34456 added a commit to inyourface34456/plastic that referenced this issue Nov 3, 2024
Amjad50 pushed a commit that referenced this issue Nov 5, 2024
@Amjad50 Amjad50 closed this as completed Nov 5, 2024
@Amjad50
Copy link
Owner

Amjad50 commented Nov 5, 2024

Implemented in #43

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants