Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes a couple of things related to airshots.
It mostly includes a bunch of changes which I'd like to see get added/changed partially to allow for better custom log parsing.
Crossbow bolt hits now count as airshots (only on damage)
Pretty self explanatory in general a "fun feature" to have.
Airshots use a "RayHull" to check for the distance to the ground
This prevents some edge cases where the center of the players isn't above solid ground but the other 40% of the hitbox are.
I think there's a debate to be had if this should be implemented...
Added a direct property to indicate rockets/pipes directly hitting an opponent
Would allow for better identifying direct hit airshots and other things. Sadly a workaround for pipes needed to be added since the event "projectile_direct_hit" gets triggered after the damage event in tf2s source code (see: this)
Added a height property to indicate the distance from the player to the ground when they got airshot
Would allow for some kind of filtering between "good" and "bad" airshots. I was considering adding this to the airshot property but logs.tf doesn't seem to parse this properly.
Like I mentioned these are mostly suggestions and I'm most of it is up to debate if it should even be implemented.
I'd of course be willing to update/change things if needed :)