Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

websocket run infinitely even server is dead #96

Closed
exitNA opened this issue Sep 10, 2023 · 1 comment
Closed

websocket run infinitely even server is dead #96

exitNA opened this issue Sep 10, 2023 · 1 comment

Comments

@exitNA
Copy link

exitNA commented Sep 10, 2023

hello:
I start a ws request, but it has an error response, but doesn't stop.
image
AnWeber added a commit to AnWeber/httpyac that referenced this issue Sep 10, 2023
@AnWeber
fix: resolve connect Promise on close before open (AnWeber/httpbook#96)
2b42690
AnWeber added a commit to AnWeber/httpyac that referenced this issue Sep 10, 2023
@AnWeber
fix: resolve connect Promise on close before open (AnWeber/httpbook#96)
3ed9ce5
@AnWeber
Copy link
Owner

AnWeber commented Sep 10, 2023

I did not take into account that an error can occur during the connection setup and the connection is closed directly. In this case the Promise was not resolved. With the next version of vscode-httpyac it is also corrected in httpbook.

@AnWeber AnWeber closed this as completed Sep 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@exitNA @AnWeber